Closed Bug 727497 Opened 9 years ago Closed 9 years ago

Don't call CreateSurfaceForWindow in MakeCurrent in EGL

Categories

(Core :: Graphics, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: BenWa, Assigned: BenWa)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
I don't think it make sense to call CreateSurface in EGL. We're not ready to provide a surface in all cases, in particular shutdown in Maple.

I suggest that we bind a context with a surface. This lets shutdown continue without deadlocking/crashing.

I plan on also landing this fix on m-c to reduce the merge diff.
Attachment #597456 - Flags: review?
Attachment #597456 - Flags: review? → review?(ajuma)
Comment on attachment 597456 [details] [diff] [review]
patch

Review of attachment 597456 [details] [diff] [review]:
-----------------------------------------------------------------

I'd add a comment that we're doing this to allow cleanup to proceed (as opposed to just bailing and returning false when we don't have a surface).
Attachment #597456 - Flags: review?(ajuma) → review+
Attached patch patch + commentSplinter Review
Assignee: nobody → bgirard
Attachment #597456 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #597514 - Flags: review?(ajuma)
Comment on attachment 597514 [details] [diff] [review]
patch + comment

Review of attachment 597514 [details] [diff] [review]:
-----------------------------------------------------------------

"bind the surface" -> "bind NO_SURFACE"
"wont" -> "won't"
Attachment #597514 - Flags: review?(ajuma) → review+
https://hg.mozilla.org/mozilla-central/rev/4988f2f80c44
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.