72750 - [mac] OK button in subscribe dialog fails for groups with long names

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Asa Dotzler [:asa]]

Steps to Reproduce:
1. set up news.mozilla.org server
2. open subscribe window
3. attempt to subscribe to netscape.public.mozilla.builds

Results: Clicking the OK button does not dismiss the window.  
Expected: Clicking OK dismisses subscribe window and the group is added to the
server pane.

Comment 1

[(not reading, please use [e-mail] instead)]

I got a fix for this bad boy.

curse mac and the 32 character file limits.

I should have followed my own comment, from nsNewsFolder.cpp

    // do we need to hash newsgroup name if it is too big?
    path += (const char *) newsgroupname;

working on the fix.

Comment 2

[(not reading, please use [e-mail] instead)]

fix in hand, has been sr=mscott.

I'll land it on the tip and the 0.8.1 branch.

Comment 3

[(not reading, please use [e-mail] instead)]

fix checked into the trunk.

I'll mark it fix when I land on the branch.

Comment 4

[(not reading, please use [e-mail] instead)]

fixed on both the trunk and the branch.

on the trunk I also added some try and catch statements to mailCommands.js to
that will handle (unexpected) failures, and still allow the user to close the
dialog on OK.

Comment 5

[[e-mail] (gone - use [e-mail] instead)]

VERIFIED FIXED.  Build 2001032108 allows me to subscribe and confirm the
subscription with the OK button on Mac OS 9.1 (using news.mcom.com with
netscape.public.mozilla.mail-news.)

Comment 6

[Asa Dotzler [:asa]]

verified on the branch.  Thanks Seth.  You totally rock!