727512 - Page that opens windows endlessly can't be closed and crashes Fennec eventually (java.lang.RuntimeException: Unable to start activity ComponentInfo{org.mozilla.fennec/org.mozilla.gecko.TabsTray}: java.util.ConcurrentModificationException)

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Martijn Wargers (dead)]

Attachment: testcase

See testcase, steps to reproduce:
- Tap on the 'open windows endlessly' button, which endlessly opens windows
- Tap on the button to the right of the url bar, to open the tab list popup
- Tap on the close button of the page with the 'open windows endlessly' button

Expected result:
- That page is closed and no new windows are being opened

Actual result:
- That page doesn't get closed and new windows are kept being opened

If I try to close a couple of pages more, or just wait I crash on the Galaxy S2:
https://crash-stats.mozilla.com/report/index/bp-893668f0-e6a6-4eaa-877b-2899d2120215
0 	libmozalloc.so 	TouchBadMemory 	memory/mozalloc/mozalloc_abort.cpp:68
1 	libmozalloc.so 	mozalloc_abort 	memory/mozalloc/mozalloc_abort.cpp:89
2 	libdvm.so 	dexDataMapAlloc 	
3 	libmozglue.so 	__res_nsend 	other-licenses/android/res_send.c:942
4 		@0xbe9eee02 	
5 	app_process 	app_process@0x32 	
6 	app_process 	app_process@0xb1e 

On the HTC Desire HD, the Android OS just seems to close Fennec.

Comment 1

[Scoobidiver (away)]

java.lang.RuntimeException: Unable to start activity ComponentInfo{org.mozilla.fennec/org.mozilla.gecko.TabsTray}: java.util.ConcurrentModificationException
	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:1651)
	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:1667)
	at android.app.ActivityThread.access$1500(ActivityThread.java:117)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:935)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:123)
	at org.mozilla.gecko.GeckoApp$32.run(GeckoApp.java:1783)
	at android.os.Handler.handleCallback(Handler.java:587)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:123)
	at android.app.ActivityThread.main(ActivityThread.java:3691)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:507)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:847)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:605)
	at dalvik.system.NativeStart.main(Native Method)
Caused by: java.util.ConcurrentModificationException
	at java.util.HashMap$HashIterator.nextEntry(HashMap.java:796)
	at java.util.HashMap$ValueIterator.next(HashMap.java:828)
	at org.mozilla.gecko.Tabs.refreshThumbnails(Tabs.java:308)
	at org.mozilla.gecko.TabsTray.onCreate(TabsTray.java:111)
	at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1047)
	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:1615)
	...

Comment 2

[Scoobidiver (away)]

I add the Aurora crash signature.

Comment 3

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Java crash; nom-ing for blocking fennec

Comment 4

[Scoobidiver (away)]

Martijn, is it reproducible?

Comment 5

[Martijn Wargers (dead)]

Sorry, I missed that needinfo? call, it seems to be wfm in current trunk build.
Fennec seems to close after a while, but the crash reporter doesn't come up, so I think it's an oom close or something.