727598 - Create icons for new Next and Previous message buttons created in bug 235666

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[:aceman]

This is a followup bug to bug 235666, where new buttons for Next (read) and Previous (read) message buttons were implemented. But they reuse the existing icons used for Next/Previous (Unread) message.

So new icons should be created to differentiate the functions, as the button labels are intentionally identical.

Currently thre next/previous icons contain 2 blue arrows (at least in gnomestripe theme). Maybe the same design with 1 arrow could be drawn.

This bug needs somebody who knows to create those icons and land them into the theme files (mail-toolbar.png and mail-toolbar-small.png).

After that I can make the necessary css updates in the theme to make the buttons use the new icons.

Comment 1

[:aceman]

Anybody working on this could also note bug 243480. Maybe all the 4 icons could be updated.

Comment 2

[:aceman]

Andreas, I got a hint you could be the right person for this.

Comment 3

[Andreas Nilsson (:andreasn)]

(In reply to :aceman from comment #2)
> Andreas, I got a hint you could be the right person for this.

Yes, new icons coming up!

Comment 4

[Andreas Nilsson (:andreasn)]

Attachment: pinstripe mail-toolbar proposal

I'll upload a variant that takes bug 243480 into account as well shortly.

Comment 5

[:aceman]

Bwinton, do you actually agree with bug 243480?

Comment 6

[:aceman]

Andreas, I do not understand the proposal. Which are the new icons in the image?

Comment 7

[Blake Winton (:bwinton) (:☕️)]

Yeah, the selection moves up and down, not left and right, so having previous and next go that way makes sense to me, too.

Comment 8

[Andreas Nilsson (:andreasn)]

Attachment: pinstripe mail-toolbar proposal 2

And this version with the arrows pointing down. It's the two icons to the very right (the regular next&previous icons are also fixed).

Comment 9

[:aceman]

Ok, thanks. What are those 2 joined bullets in the icons?

Comment 10

[Andreas Nilsson (:andreasn)]

it's the same icon we use for "read"

Comment 11

[Andreas Nilsson (:andreasn)]

if these are ok I'll do qute and gnomestripe as well.

Comment 12

[:aceman]

Comment on attachment 627880 [details]
pinstripe mail-toolbar proposal 2

I do not have much opinion on how they should look like. I take anything.
I can only test the gnomestripe version.

Comment 13

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 627880 [details]
pinstripe mail-toolbar proposal 2

Yeah, I like those…  ui-r=me!

Thanks,
Blake.

Comment 14

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 627880 [details]
pinstripe mail-toolbar proposal 2

(I would be even cooler if I actually remembered to change the ui-review flag to + when I gave my ui-r+…  ;)

Comment 15

[Andreas Nilsson (:andreasn)]

Attachment: new icons for all platforms

Still needs css.

Comment 16

[:aceman]

I can do the css if you wish.

Comment 17

[Andreas Nilsson (:andreasn)]

Attachment: icons+css

Need to actually try it in action on all platforms first, but I think this should do the trick.

Comment 18

[Andreas Nilsson (:andreasn)]

Attachment: icons+css v2

Had accidentally switched the numbers around for unread and regular next/previous. This also takes out the rtl variants, as the graphics now goes up and down.

Comment 19

[:aceman]

Thanks, I'll try it out.

Comment 20

[:aceman]

Comment on attachment 631406 [details] [diff] [review]
icons+css v2

Thanks! I can confirm the new icons work in Linux (gnomestripe), LTR setup, both normal and small toolbar and standalone message window.

Comment 21

[Andreas Nilsson (:andreasn)]

Comment on attachment 631406 [details] [diff] [review]
icons+css v2

Setting up for review

Comment 22

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 631406 [details] [diff] [review]
icons+css v2

Okay, I know this is totally a dick-move, but when I see the next-unread/previous-unread, I'm not really happy with the sunglasses (at least on OS X).  We aren't using them in the QFB, or in the message-list-header, so they seem odd and out-of-place.  What do you think about a double-up-arrow/double-down-arrow instead?  Or making them the same as the next/previous icons, like we do now?

Sorry about that,
Blake.

Comment 23

[:aceman]

They should not be the same, the point of this bug is to distinguish them.
But making the prev/next be 1 arrow, and prev/next unread be 2 arrows was in the original proposal :)

Comment 24

[Blake Winton (:bwinton) (:☕️)]

Yeah, I'm really sorry about that.  :(

Comment 25

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 631406 [details] [diff] [review]
icons+css v2

Removing r? until the icons issue is resolved.

Comment 26

[:aceman]

Attachment: icons proposal

So here is my proposal, based on gnomestripe theme. Rotate existing prev/next unread icons (double tip-of-an-arrow) and add new icons for prev/next read action (single tip-of-an-arrow). Other themes do not seem to use the white sheet behind the arrows, so adapt each theme as necessary (actually, copy existing double arrow and make single arrow version, and rotate both).

This is just a mockup, please align the arrows nicely in the final icons (so they can't be just 90deg rotations, there need to be some adjustments).

Comment 27

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 636439 [details]
icons proposal

I think this works for me.  I'ld like to see what it would look like on the other platforms, too, but I understand if you can't do that, aceman…

Thanks,
Blake.

Comment 28

[:aceman]

I could do it, but it is mostly the same. I just wanted to show both of you how the directions and double/single arrows are meant.

Comment 29

[Andreas Nilsson (:andreasn)]

Comment on attachment 636439 [details]
icons proposal

I'm planning on dropping the sheets behind those icons, but apart from that, I agree with this plan.

Comment 30

[Andreas Nilsson (:andreasn)]

Attachment: new icons based on acemans sketch

Here are the new icons, replacing the files that bitrotted with the landing of #748358. Updated css coming shortly.

Comment 31

[Andreas Nilsson (:andreasn)]

Attachment: new icons, new css

Same as above, with some css. Badly formatted right now.

Comment 32

[:aceman]

Comment on attachment 636784 [details] [diff] [review]
new icons, new css

Why did the css need change? Wasn't the previous version fine just the icons needed replacement?

Comment 33

[Andreas Nilsson (:andreasn)]

It's the same css, just not bitrotted.

Comment 34

[:aceman]

Comment on attachment 636784 [details] [diff] [review]
new icons, new css

Great, just tested the patch on gnomestripe and the icons are nice, as I proposed. Only I think you got them swapped in the css. The double arrow now does "next/prev read" instead of "next/prev unread" as before.

Comment 35

[Andreas Nilsson (:andreasn)]

Attachment: new icons and css (v3)

Comment 36

[:aceman]

Comment on attachment 637068 [details] [diff] [review]
new icons and css (v3)

Thanks, this is what I had in mind.

Comment 37

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 637068 [details] [diff] [review]
new icons and css (v3)

Awesome!  ui-r=me!

Later,
Blake.

Comment 38

[:aceman]

The patch is just css and icon files. Who can review that?

Comment 39

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 637068 [details] [diff] [review]
new icons and css (v3)

(In reply to :aceman from comment #38)
> The patch is just css and icon files. Who can review that?

Good question.  I can.  r=me.  :)

Later,
Blake.

Comment 40

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/bcd212ed28fc

Comment 41

[Thomas Sisson]

In the default theme for Thunderbird 16.0.2 on Ubuntu 12.10, the next arrow points up until you put the mouse over it. Many themes that work well in the Linux such as Silvermel still do not have Previous and Next icons. Oxygenate, the perfect theme while using the KDE manager, is no longer compatible. Is there a way for all themes to fall back to a default icon if it is not defined in a theme? If there is, I think that this should be a requirement for all themes uploaded to Mozilla Add-ons. Themes, just as extensions, available at other websites would be downloaded and installed at the risk of the user for quality, functionality, and malicious code.

Comment 42

[:aceman]

The Ubuntu icon problem is bug 801514. Ubuntu uses a different theme than Thunderbird ships for Linux.