727685 - Compile time error for unused variable 'invmatrix' on nsSVGForeignObjectFrame

Status: RESOLVED INVALID

(Core :: Layout: Block and Inline, defect)

Description

[Thinker Li [:sinker]]

invmatrix is only used for assertion.  It dues to a compiling time error for unused variable.

Comment 1

[Thinker Li [:sinker]]

Attachment: Fix the compile time error for unused variable invmatrix

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 597638 [details] [diff] [review]
Fix the compile time error for unused variable invmatrix

Review of attachment 597638 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with that

::: layout/svg/base/src/nsSVGForeignObjectFrame.cpp
@@ +273,5 @@
>    gfx->Multiply(matrixForChildren);
>  
>    // Transform the dirty rect into the rectangle containing the
>    // transformed dirty rect.
> +  mozilla::DebugOnly<gfxMatrix> invmatrix = matrix.Invert();

Instead of a mozilla:: prefix here, just add "using namespace mozilla;" after the #includes.

Comment 3

[Thinker Li [:sinker]]

Attachment: Fix the compile time error for unused variable invmatrix, v2

updated as the suggestion of comment 2.

Comment 4

[Mozilla RelEng Bot]

Try run for b6c7a39cd692 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=b6c7a39cd692
Results (out of 133 total builds):
    success: 110
    warnings: 10
    failure: 13
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-b6c7a39cd692

Comment 5

[Thinker Li [:sinker]]

Attachment: Fix the compile time error for unused variable invmatr ix, v3

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

I don't like it. matrix.Invert() actually changes the matrix, unnecessarily in opt builds. I'd add a little helper

#ifdef DEBUG
const gfxMatrix&
Inverse(const gfxMatrix& aMatrix)
{
  gfxMatrix matrix = aMatrix;
  return matrix.Invert();
}
#endif

And then change the two assertions in this function by

NS_ASSERTION(!Inverse(matrix).IsSingular(),
             "inverse of non-singular matrix should be non-singular");

Or something like that

Comment 7

[Robert Longson [:longsonr]]

This code was removed in bug 727212

Comment 8

[Mozilla RelEng Bot]

Try run for c0cded1d82ce is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=c0cded1d82ce
Results (out of 212 total builds):
    success: 175
    warnings: 23
    failure: 14
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-c0cded1d82ce