727697 - Add a facility to capture played audio to WAV files for debugging

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: possible patch

I found this tremendously useful while debugging, but this may not be the right long-term solution especially if/when we move away from nsBufferedAudioStream to use libcubeb directly. In which case we might want something at the libcubeb level, or directly in the GraphManager. Whatever you think.

Comment 2

[Matthew Gregan [:kinetik]]

Comment on attachment 597665 [details] [diff] [review]
possible patch

Doing disk I/O from this callback seems like a very bad idea.  Do you need to be able to play the audio to real hardware and save it to disk at the same time?  If not, adding a Wave/raw PCM backend to cubeb would be once approach.  If you need playback and write out at the same time, the disk I/O needs to be moved out of the callback.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

It works for me while I'm debugging. There's no real need to land this I guess.

Comment 5

[Matthew Gregan [:kinetik]]

Ehsan wants this too, so let's just land it.  My earlier objections were too fussy for something debug-only.

Comment 6

[(no longer active)]

Rebased and landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/bdf9d4faddd9

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bdf9d4faddd9