Closed Bug 727709 Opened 11 years ago Closed 11 years ago

Papercut: add mention of "default" to server chooser in Firefox Sync setup

Categories

(Firefox :: Sync, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla13

People

(Reporter: rnewman, Unassigned)

References

Details

(Whiteboard: [verified in services])

Attachments

(1 file, 1 obsolete file)

Currently says "Firefox Sync Server". Should say "Default: Mozilla Firefox Sync server".

Use appropriate entities, of course.
browser/locales/en-US/chrome/browser/syncSetup.dtd

15:<!ENTITY serverType.main.label      "&syncBrand.fullName.label; Server">

Replace this entity with one with a different name and string.
Blocks: 720873
Attached patch Possible patch (obsolete) — Splinter Review
Haven't changed the entity-name yet, but this works. Is it within my discretion what name I should choose? Seeing as changing the name of the entity would require modifying the XML file too.
Thanks for the patch, Pranav!
 
> Haven't changed the entity-name yet, but this works.

Nit: lowercase "Server". It shouldn't really have been capitalized to start with.

> Is it within my discretion what name I should choose?

I'd suggest "serverType.default.label", but I'd be open to better suggestions.

> Seeing as changing the name of the
> entity would require modifying the XML file too.

Yup!
Attached patch Proposed patchSplinter Review
Attachment #597884 - Attachment is obsolete: true
Comment on attachment 598152 [details] [diff] [review]
Proposed patch

Review of attachment 598152 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Thanks Pranav!
Attachment #598152 - Flags: review+
Steps to verify should be pretty clear, I think: check that the string in the Setup Wizard is different.

https://hg.mozilla.org/services/services-central/rev/01798c76c3b3
Whiteboard: [good first bug][mentor=rnewman] → [fixed in services]
Verified with s-c train build of 20120221
Whiteboard: [fixed in services] → [verified in services]
https://hg.mozilla.org/mozilla-central/rev/01798c76c3b3

This has been merged into mozilla-central and will be part of Firefox 13. Thank you for contributing, Pranav!
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
Status: RESOLVED → VERIFIED
Component: Firefox Sync: UI → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.