727709 - Papercut: add mention of "default" to server chooser in Firefox Sync setup

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Richard Newman [:rnewman]]

Currently says "Firefox Sync Server". Should say "Default: Mozilla Firefox Sync server".

Use appropriate entities, of course.

Comment 1

[Richard Newman [:rnewman]]

browser/locales/en-US/chrome/browser/syncSetup.dtd

15:<!ENTITY serverType.main.label      "&syncBrand.fullName.label; Server">

Replace this entity with one with a different name and string.

Comment 2

[Pranav Ravichandran [:pranavrc]]

Attachment: Possible patch

Haven't changed the entity-name yet, but this works. Is it within my discretion what name I should choose? Seeing as changing the name of the entity would require modifying the XML file too.

Comment 3

[Richard Newman [:rnewman]]

Thanks for the patch, Pranav!
 
> Haven't changed the entity-name yet, but this works.

Nit: lowercase "Server". It shouldn't really have been capitalized to start with.

> Is it within my discretion what name I should choose?

I'd suggest "serverType.default.label", but I'd be open to better suggestions.

> Seeing as changing the name of the
> entity would require modifying the XML file too.

Yup!

Comment 4

[Pranav Ravichandran [:pranavrc]]

Attachment: Proposed patch

Comment 5

[Richard Newman [:rnewman]]

Comment on attachment 598152 [details] [diff] [review]
Proposed patch

Review of attachment 598152 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Thanks Pranav!

Comment 6

[Richard Newman [:rnewman]]

Steps to verify should be pretty clear, I think: check that the string in the Setup Wizard is different.

https://hg.mozilla.org/services/services-central/rev/01798c76c3b3

Comment 7

[Tracy Walker [:tracy]]

Verified with s-c train build of 20120221

Comment 8

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/01798c76c3b3

This has been merged into mozilla-central and will be part of Firefox 13. Thank you for contributing, Pranav!