727728 - Support volume change

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[[:fabrice] Fabrice Desré]

Currently the volume is always at 1 (max).

Comment 1

[[:fabrice] Fabrice Desré]

Attachment: patch

Changes the volume in 1/20 steps. Works fine when watching videos from the video app.

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

(In reply to Fabrice Desré [:fabrice] from comment #0)
> Currently the volume is always at 1 (max).

I don't think this actually gets applied currently, because volume in video is definitely below what the speakers are capable of.

Comment 3

[Philipp von Weitershausen [:philikon]]

Comment on attachment 597701 [details] [diff] [review]
patch

Nice! 

>+  changeVolume: function shell_changeVolume(aDelta) {
>+    let audioManager = Cc["@mozilla.org/telephony/audiomanager;1"].getService(Ci.nsIAudioManager);

nit: overlong line?

>+          case 'VolumeUp':
>+            this.changeVolume(0.05);
>+            break;
>+          case 'VolumeDown':
>+            this.changeVolume(-0.05);
>+            break;

nit: would be nice to have that increment/decrement const'ed.

Also, 20 steps is quite a lot. I don't know of any UI that has that many steps. 10 might be enough. Just sayin'.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

> Also, 20 steps is quite a lot. I don't know of any UI that has that many
> steps. 10 might be enough. Just sayin'.

I tend to agree on that. 20 steps seems a bit too much.

What about a pref, so the rest of the world will be able to tweak it if they prefer less or more.

Comment 5

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/mozilla-inbound/rev/32d556a79784

using the "media.volume.steps" pref that defaults to 10.

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/32d556a79784