727735 - don't use computed style for width detection in IsProbablyForLayout

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

Attachment: patch

GetComputedStyleValue for width doesn't make any sense because it returns width value in px regardless of style="width" usage.

covered by table/test_layoutguess.html

Comment 1

[Trevor Saunders (:tbsaunde)]

Comment on attachment 597707 [details] [diff] [review]
patch

yeah, just looking at what the result is seems fairly reasonable.  I'm a little concerned about the case of really long columns but that's probaby really rare.

Comment 2

[alexander :surkov (:asurkov)]

(In reply to Trevor Saunders (:tbsaunde) from comment #1)
> Comment on attachment 597707 [details] [diff] [review]
> patch
> 
> yeah, just looking at what the result is seems fairly reasonable.  I'm a
> little concerned about the case of really long columns but that's probaby
> really rare.

provide an example/file a bug? we always have a room to improve our layoutguess logic.

Comment 3

[alexander :surkov (:asurkov)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/121daf1e632b

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/121daf1e632b