727764 - migrate syncreg to pyramid/cornice/mozsvc

Status: VERIFIED WONTFIX

(Cloud Services :: Server: Registration, defect)

Description

[Ryan Kelly [:rfkelly]]

Attachment: patch migrating syncreg to pyramid

This patch updates SyncReg to use our new pyramid-based infrastructure.  Major changes:
  * merge .ini/.conf files into a single .ini file
  * replace wsgiapp.py with views.py
  * controller tweaks for changed settings management

Required as part of making server-full use the updated server-syncstorage code.

Comment 1

[Toby Elliott [:telliott]]

Regardless of patch status, I think this is a WONTFIX for any external release. We're never going to be in a situation where we want to support reg+cornice - we'll support the one we have out there right now, and then it's over to whatever BID brings.

Comment 2

[Tarek Ziadé (:tarek)]

Comment on attachment 597738 [details] [diff] [review]
patch migrating syncreg to pyramid

>diff --git a/etc/production.ini b/etc/production.ini
>index 843cf74..0c1c552 100644
>--- a/etc/production.ini
>+++ b/etc/production.ini
...
>+    return config.make_wsgi_app()
>diff --git a/syncreg/controllers/static.py b/syncreg/controllers/static.py
>index 026e1ac..bd23f8a 100644
>--- a/syncreg/controllers/static.py
>+++ b/syncreg/controllers/static.py
...
> 
>@@ -20,12 +20,12 @@ _STATIC_DIR = os.path.join(os.path.dirname(__file__), '..', 'static')
> class StaticController(object):
>     """Used to return static files
>     """

Why an empty __init__ here ? what's the intent ?

>-    def __init__(self, app):
>-        self.app = app
>+    def __init__(self, config):
>+        pass



other than that seems to look good. But I would not bother migrating (s)reg

Comment 3

[Ryan Kelly [:rfkelly]]

Thanks guys, resolving wontfix for the reasons you've outlined above.

Comment 4

[James Bonacci [:jbonacci]]

OK.