Closed Bug 727793 Opened 12 years ago Closed 12 years ago

Status panel tracks the mouse position on the wrong side when using a RTL locale

Categories

(Firefox :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 13
Tracking Status
firefox11 --- unaffected
firefox12 --- verified

People

(Reporter: dao, Assigned: dao)

References

Details

(Keywords: regression, Whiteboard: [qa+])

Attachments

(1 file)

This is due to a typo (alighRight vs. alignRight).
Attached patch patchSplinter Review
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #597780 - Flags: review?(gavin.sharp)
Attachment #597780 - Flags: review?(gavin.sharp) → review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/1a8ab7400323
Target Milestone: --- → Firefox 13
https://hg.mozilla.org/mozilla-central/rev/1a8ab7400323
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Attachment #597780 - Flags: approval-mozilla-aurora?
Comment on attachment 597780 [details] [diff] [review]
patch

[Triage Comment]
Approving for Aurora 12 to fix this code typo.
Attachment #597780 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Is there a test to verify this fix?
Whiteboard: [qa?]
This can be tested manually in RTL builds. There's no automated test.
(In reply to Dão Gottwald [:dao] from comment #7)
> This can be tested manually in RTL builds. There's no automated test.

How does one test this fix?
You move the mouse over the status panel.
(In reply to Dão Gottwald [:dao] from comment #9)
> You move the mouse over the status panel.

And what happens if it's still broken?
Nothing.
(In reply to Dão Gottwald [:dao] from comment #11)
> Nothing.

Okay...then what happens if this is not broken?
The same thing that happens in a non-RTL build (it switches sides).
Sorry guys, I'm a bit confused, and this back and forth is not working for me. Can you please be a bit more explicit?

Here is what I am assuming:
1) Hover over a link
2) On RTL locale, URL displays on bottom-right
3) On LTR locale, URL displays on bottom-left
Mousing over the status panel should make the panel move to the other side of the screen. This bug was about that behavior being broken in RTL builds.
You'd need a link at the bottom edge of the window for that, otherwise you can't try to move the mouse over the status panel while still hovering over the link. It's easier if you load a large page, which will display the status panel as long as the page loads.
You can also tab to a link to get the status panel to show.
Thank you for the clarification.
Whiteboard: [qa?] → [qa+]
Mozilla/5.0 (Windows NT 6.1; rv:12.0) Gecko/20100101 Firefox/12.0
Mozilla/5.0 (X11; Linux i686; rv:12.0) Gecko/20100101 Firefox/12.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:12.0) Gecko/20100101 Firefox/12.0

Checked with Arabian locale Firefox for beta 4 on Mac Os 10.6, Ubuntu 11.10 and Widnows 7.

Loaded planet.mozilla.org. Moved the mouse to the right status panel.
The panel moves to the other side of the screen.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: