Closed
Bug 727805
Opened 12 years ago
Closed 12 years ago
Give aFactor in nsDisplayList.cpp a more meaningful name
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: jwatt, Assigned: jwatt)
Details
Attachments
(1 file)
|
13.54 KB,
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
In nsDisplayList.cpp the aFactor arguments are not very helpfully named when it comes to understanding the code. aAppUnitsPerPixel would be a better name.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #597790 -
Flags: review?(matt.woodrow)
|
|
Assignee | |
Comment 2•12 years ago
|
||
The assumption that aFactor must contain an app unit to px factor is implicit in the use of NSAppUnitsToFloatPixels in these functions. Incidentally, NSAppUnitsToFloatPixels calls its argument aAppUnitsPerPixel too.
|
||
Updated•12 years ago
|
Attachment #597790 -
Flags: review?(matt.woodrow) → review+
|
||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2d3e158dbd49
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in
before you can comment on or make changes to this bug.
Description
•