from Bugzilla Bug 70989 Clean up lots of "shadows" and other common warnings * mailnews/addrbook: - nsCOMPtr<nsISupports> pSupport = getter_AddRefs(pAddressLists->ElementAt(j)); + pSupport = getter_AddRefs(pAddressLists->ElementAt(j)); nsCOMPtr<nsIAbCard> cardInList(do_QueryInterface(pSupport, &rv)); You have tabs here in your + line, and can we use QueryElementAt to save the explicit QI?
note to self: I think I have another bug somewhere else about this. (Those who fail to patch before are bound to report their bugs again and patch later...)
Timeless said (over irc) I could take this one off him, therefore re-assigning.
Created attachment 183763 [details] [diff] [review] Patch This patch fixes the only case I could find in address book where this happens.
Comment on attachment 183763 [details] [diff] [review] Patch Requesting approval for checkin for this minor change - it is a small code tidy up that affects both suite & tb, but should be low risk.
Comment on attachment 183763 [details] [diff] [review] Patch a=asa for checkin to 1.8b2/1.1a1
Timeless checked this in: 2005-05-19 13:22 timeless%mozdev.org mozilla/ mailnews/ base/ resources/ locale/ en-US/ messenger.properties 1.118 1/1
Opps try getting the right checkin ;-) 2005-05-19 13:21 timeless%mozdev.org mozilla/ mailnews/ addrbook/ src/ nsDirectoryDataSource.cpp 1.66 3/3
Verified FIXED (API-level) using LXR: http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/mailnews/addrbook/src&command=DIFF_FRAMESET&file=nsDirectoryDataSource.cpp&rev1=1.65&rev2=1.66&root=/cvsroot