72781 - rewrite getter_AddRefs(pAddressLists->ElementAt(j)) using QueryElementAt

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[timeless]

from Bugzilla Bug 70989 Clean up lots of "shadows" and other common warnings 
 * mailnews/addrbook:
   - nsCOMPtr<nsISupports> pSupport =    
         getter_AddRefs(pAddressLists->ElementAt(j));
   + pSupport = getter_AddRefs(pAddressLists->ElementAt(j));
     nsCOMPtr<nsIAbCard> cardInList(do_QueryInterface(pSupport, &rv));
   You have tabs here in your + line, and can we use QueryElementAt to save the
   explicit QI?

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Reversing database corruption caused by bug 95857 and bug 95798.  Pay no
attention to the man behind the curtain.

Comment 2

[timeless]

note to self: I think I have another bug somewhere else about this.  (Those who
fail to patch before are bound to report their bugs again and patch later...)

Comment 3

[Mark Banner (:standard8)]

Timeless said (over irc) I could take this one off him, therefore re-assigning.

Comment 4

[Mark Banner (:standard8)]

Attachment: Patch

This patch fixes the only case I could find in address book where this happens.

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 183763 [details] [diff] [review]
Patch

Requesting approval for checkin for this minor change - it is a small code tidy
up that affects both suite & tb, but should be low risk.

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 183763 [details] [diff] [review]
Patch

a=asa for checkin to 1.8b2/1.1a1

Comment 7

[Mark Banner (:standard8)]

Timeless checked this in:

2005-05-19 13:22	timeless%mozdev.org 	mozilla/ mailnews/ base/ resources/
locale/ en-US/ messenger.properties 	1.118 	1/1

Comment 8

[Mark Banner (:standard8)]

Opps try getting the right checkin ;-)

2005-05-19 13:21	timeless%mozdev.org 	mozilla/ mailnews/ addrbook/ src/
nsDirectoryDataSource.cpp 	1.66 	3/3

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED (API-level) using LXR:

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/mailnews/addrbook/src&command=DIFF_FRAMESET&file=nsDirectoryDataSource.cpp&rev1=1.65&rev2=1.66&root=/cvsroot