727823 - remove tp5r side by side staging for windows and linux

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

Now that we have adequate data to show that the new rss collection for windows and linux is working well, we need to make tp5r the default test for all platforms, not just MAC_ONLY.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: remove tp5r side by side staging for windows and linux.

Comment 2

[Armen [:armenzg]]

Comment on attachment 597806 [details] [diff] [review]
remove tp5r side by side staging for windows and linux.

Review of attachment 597806 [details] [diff] [review]:
-----------------------------------------------------------------

Cool. When would you like this in by?
Any talos.zip changes? or are we good to go?

::: mozilla-tests/config.py
@@ -254,1 @@
>      },

A lot of code but all we're doing is to fold "tpr_responsiveness_other" (NO_MAC) into "tpr_responsiveness" (MAC_ONLY) by changing it to be ALL_PLATFORMS.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: updated patch to include the paint tests (2.0)

Comment 4

[Armen [:armenzg]]

Comment on attachment 598860 [details] [diff] [review]
updated patch to include the paint tests (2.0)

Review of attachment 598860 [details] [diff] [review]:
-----------------------------------------------------------------

I am committing this right away to get it on today's reconfig: c19bf8dc0844

In the future, I think is better if we have separate patches for each thing that we want to do (clean up VS adding missed suites).
It makes it easier for reviews and in case we need to back something out.

I have one question inline about "chrome.2" changes. Thanks jmaher.

::: mozilla-tests/config.py
@@ +236,4 @@
>      'tpr_responsiveness': {
>          'enable_by_default': True,
>          'suites': GRAPH_CONFIG + ['--activeTests', 'tp5r', '--mozAfterPaint', '--responsiveness', '--ignoreFirst', '--sampleConfig', 'sample.2.config'],
> +        'options': (TALOS_TP_OPTS, ALL_PLATFORMS),

We're merging:
* [DROP] 'tp_responsiveness'; default=True, NO_MAC
and
* [DROP] 'tpr_responsiveness_other'; default=False, NO_MAC
* 'tpr_responsiveness'; default=False, MAC_ONLY
as
* 'tpr_responsiveness'; default=True, ALL_PLATFORMS

@@ +245,4 @@
>      },
>      'chrome.2': {
>          'enable_by_default': True,
> +        'suites': GRAPH_CONFIG + ['--activeTests', 'tscroll.2:a11y.2:ts_paint:tpaint:tdhtml.2:tsspider.2', '--mozAfterPaint', '--ignoreFirst', '--sampleConfig', 'sample.2.config'],

We're adding "ts_paint:tpaint".

jmaher, no .2 versions of it?

@@ +250,5 @@
>      },
>      # chrome_mac compared to chrome is that it does not contain a11y and only run on Mac
>      'chrome_mac.2': {
>          'enable_by_default': True,
> +        'suites': GRAPH_CONFIG + ['--activeTests', 'tscroll.2:ts_paint:tpaint:tdhtml.2:tsspider.2', '--mozAfterPaint', '--ignoreFirst', '--sampleConfig', 'sample.2.config'],

This is the same as the previous change but specific to mac.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

all is correct.  we did not need to modify ts_paint or paint so there is no need for a .2 version.

Comment 6

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Found during triage.

armenzg/jmaher: I see patch r+'d and checked in. Anything left to do here?

Comment 7

[Armen [:armenzg]]

Landed on Feb. 21st:
http://hg.mozilla.org/build/buildbot-configs/rev/c19bf8dc0844