727826 - Use JSON.parse() in HistoryMenu.prototype.populateUndoSubmenu()

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

In in HistoryMenu.prototype.populateUndoSubmenu(), it should use JSON.parse() insetad of using eval().

Comment 1

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: proposed patch

Comment 2

[Marco Bonardo [:mak]]

Comment on attachment 597807 [details] [diff] [review]
proposed patch

Review of attachment 597807 [details] [diff] [review]:
-----------------------------------------------------------------

good catch, looks like this is there from quite some time and I don't see a valid reason for it. This code goes back to 2006, likely we didn't yet have native json.

Comment 3

[Josh Matthews [:jdm]]

Thanks for the patch! In future, could you follow the instructions at http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed so that your patches include an author and commit message? That will make it easier for other people to check them in.

http://hg.mozilla.org/integration/mozilla-inbound/rev/1c86e1c24cbc

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1c86e1c24cbc