Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Use getSpecialFolderString() in folderWidgets.xml._setCssSelectors

VERIFIED FIXED in Thunderbird 13.0

Status

Thunderbird
Folder and Message Lists
--
trivial
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

Trunk
Thunderbird 13.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Noticed in bug 670976 comment 26.

There is duplicated code in folderWidgets.xml._setCssSelectors, which is already defined in /mailnews/base/util/folderUtils.jsm getSpecialFolderString().
(Assignee)

Comment 1

6 years ago
Created attachment 597967 [details] [diff] [review]
patch
Attachment #597967 - Flags: review?(dbienvenu)
(Assignee)

Updated

6 years ago
Status: NEW → ASSIGNED

Comment 2

6 years ago
Comment on attachment 597967 [details] [diff] [review]
patch

thx, this does seem to fix the aFolder error (that was the intent, right?). I've requested a try server build to make sure mozmill tests still pass, but it looks good to me.
Attachment #597967 - Flags: review?(dbienvenu) → review+
(Assignee)

Comment 3

6 years ago
No, this will actually confuse the debugging even more, it should now throw inside getSpecialFolderString, where aFolder.flags is accessed.

Attempt to solve the error is properly separated in bug 670976.
(Assignee)

Comment 4

6 years ago
This bug is just code-deduplication, no behaviour change intended.

Comment 5

6 years ago
(In reply to :aceman from comment #3)
> No, this will actually confuse the debugging even more, it should now throw
> inside getSpecialFolderString, where aFolder.flags is accessed.

that exception seems to get caught and suppressed; I don't see anything on the error console anymore.
(Assignee)

Comment 6

6 years ago
If you didn't apply patch from bug 670976 too then it would be strange. The change here should not have the effect of suppressing it. Do you have proper STRs? Maybe exceptions are hidden inside .jsm files?
Just place an alert (or other dump) before the line
'aMenuNode.setAttribute("SpecialFolder", getSpecialFolderString(aFolder));' and you should see aFolder is undefined.
(Assignee)

Comment 7

6 years ago
So what are your results? What about the trybuild?
This patch alone should not intentionally hide the error.

Comment 8

6 years ago
(In reply to :aceman from comment #7)
> So what are your results? What about the trybuild?
> This patch alone should not intentionally hide the error.

turns out my STR's (the run message filter steps) were not reliable, though I did try it a couple times w/ and w/o the patch. So ignore me.
(Assignee)

Comment 9

6 years ago
So does the r+ hold?

Comment 10

6 years ago
(In reply to :aceman from comment #9)
> So does the r+ hold?

sure, it's good to remove the code duplication, thx.
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
Checked in: http://hg.mozilla.org/comm-central/rev/d182f15b6b63
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 13.0
(Assignee)

Updated

6 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.