Make nsWrapperCache::WrapObject take a JSObject scope instead of XPCWrappedNativeScope

RESOLVED FIXED in mozilla14

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mrbkap, Assigned: mrbkap)

Tracking

unspecified
mozilla14
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 597870 [details] [diff] [review]
patch v1

For the new DOM bindings, we won't have XPCWrappedNatives lying around. However, we are going to piggy-back on nsWrapperCache::WrapObject, so that function's signature needs to be amenable to both the old and new world.
Attachment #597870 - Flags: review?(peterv)
Comment on attachment 597870 [details] [diff] [review]
patch v1

Review of attachment 597870 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like you might be able to wrap a lot of the lines where you did s/XPCWrappedNativeScope/JSObject/.
Attachment #597870 - Flags: review?(peterv) → review+
Blake, anything stopping this from landing on central?
Except from Peter's bitrot, that is...
(Assignee)

Comment 4

5 years ago
Comment on attachment 597870 [details] [diff] [review]
patch v1

https://hg.mozilla.org/integration/mozilla-inbound/rev/c5af61992920 with some merging.
Attachment #597870 - Flags: checkin+
https://hg.mozilla.org/mozilla-central/rev/c5af61992920
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.