727884 - Make nsWrapperCache::WrapObject take a JSObject scope instead of XPCWrappedNativeScope

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: patch v1

For the new DOM bindings, we won't have XPCWrappedNatives lying around. However, we are going to piggy-back on nsWrapperCache::WrapObject, so that function's signature needs to be amenable to both the old and new world.

Comment 1

[Peter Van der Beken [:peterv]]

Comment on attachment 597870 [details] [diff] [review]
patch v1

Review of attachment 597870 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like you might be able to wrap a lot of the lines where you did s/XPCWrappedNativeScope/JSObject/.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Blake, anything stopping this from landing on central?

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Except from Peter's bitrot, that is...

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 597870 [details] [diff] [review]
patch v1

https://hg.mozilla.org/integration/mozilla-inbound/rev/c5af61992920 with some merging.

Comment 5

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/c5af61992920