Closed Bug 727884 Opened 8 years ago Closed 8 years ago

Make nsWrapperCache::WrapObject take a JSObject scope instead of XPCWrappedNativeScope

Categories

(Core :: DOM: Core & HTML, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: mrbkap, Assigned: mrbkap)

Details

Attachments

(1 file)

Attached patch patch v1Splinter Review
For the new DOM bindings, we won't have XPCWrappedNatives lying around. However, we are going to piggy-back on nsWrapperCache::WrapObject, so that function's signature needs to be amenable to both the old and new world.
Attachment #597870 - Flags: review?(peterv)
Comment on attachment 597870 [details] [diff] [review]
patch v1

Review of attachment 597870 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like you might be able to wrap a lot of the lines where you did s/XPCWrappedNativeScope/JSObject/.
Attachment #597870 - Flags: review?(peterv) → review+
Blake, anything stopping this from landing on central?
Except from Peter's bitrot, that is...
https://hg.mozilla.org/mozilla-central/rev/c5af61992920
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.