727914 - [One Mozilla - Tabzilla] Minify tabzilla JS and CSS reference code on mozilla.org

Status: RESOLVED WONTFIX

(Websites :: Tabzilla, defect)

Description

[Fred Wenzel [:wenzel]]

Tabzilla -- to be used by many websites -- is deployed as unminified JS and CSS on mozilla.org right now, that's kind of sad for performance. Can we deploy this as minified code instead?

Comment 1

[Fred Wenzel [:wenzel]]

URLs are:
http://www.mozilla.org/tabzilla/media/css/tabzilla.css
http://www.mozilla.org/tabzilla/media/css/tabzilla.css

Comment 2

[Fred Wenzel [:wenzel]]

(In reply to Fred Wenzel [:wenzel] from comment #1)
> URLs are:
> http://www.mozilla.org/tabzilla/media/css/tabzilla.css
> http://www.mozilla.org/tabzilla/media/css/tabzilla.css

Uh, I mean:
http://www.mozilla.org/tabzilla/media/js/tabzilla.js

Comment 3

[Kohei Yoshino [:kohei]]

Sorry for the bugspam -- the Target Milestore was set unexpectedly.

Comment 6

[Paul [:pmac] McLanahan]

Much has changed since the filing of this bug. The CSS is in fact now minified and both the JS and CSS are served by a global CDN. The new urls and installation instructions are:

http://bedrock.readthedocs.org/en/latest/tabzilla.html

The JS is indeed not yet being minified because it is a dynamic view. We've discussed on-the-fly minification in bug 959359, and I believe we should do that. Our webservers do gzip JS when requested, and that reduces the size of tabzilla.js from 29k to 9.6k. But you're right that this could be further reduced. Hopefully we can knock this out soon.

Comment 7

[Paul [:pmac] McLanahan]

My recommended library for doing this is https://github.com/rspivak/slimit

Comment 8

[Christopher Van Wiemeersch [:cvan]]

While we're at it, can we stop tabzilla from loading jquery (especially if we detect it's already on the page)?

https://www.dropbox.com/s/8syeiyf4wv5tl5h/Screenshot%202014-10-01%2014.21.14.png?dl=0

Comment 9

[Steven Garrity [:sgarrity]]

(In reply to Christopher Van Wiemeersch [:cvan] from comment #8)
> While we're at it, can we stop tabzilla from loading jquery (especially if
> we detect it's already on the page)?
> 
> https://www.dropbox.com/s/8syeiyf4wv5tl5h/Screenshot%202014-10-01%2014.21.14.
> png?dl=0

Tabzilla should only be loading jQuery if the page doesn't already provide a sufficient version. See https://github.com/mozilla/bedrock/blob/master/media/js/test/spec/tabzilla.js#L12

Comment 10

[Christopher Van Wiemeersch [:cvan]]

(In reply to Steven Garrity [:sgarrity] from comment #9)
> (In reply to Christopher Van Wiemeersch [:cvan] from comment #8)
> > While we're at it, can we stop tabzilla from loading jquery (especially if
> > we detect it's already on the page)?
> > 
> > https://www.dropbox.com/s/8syeiyf4wv5tl5h/Screenshot%202014-10-01%2014.21.14.
> > png?dl=0
> 
> Tabzilla should only be loading jQuery if the page doesn't already provide a
> sufficient version. See
> https://github.com/mozilla/bedrock/blob/master/media/js/test/spec/tabzilla.
> js#L12

I wonder if tabzilla can do be backwards compatible with older versions of jQuery. And what would it take for tabzilla to eliminate its dependency on jQuery?

I filed bug 1076389 on AMO's side.

Comment 11

[Jennifer Bertsch [:jbertsch]]

Note:  Jen to discuss this with Josh and Pmac in the context of:  2015 roadmap and possible upcoming changes to Tabzilla

Comment 12

[Kohei Yoshino [:kohei]]

As you might know, Bug 1151579 has replaced Tabzilla with a static Mozilla tab. The old assets are still available, but no site is probably using it. Closing all Tabzilla-related open bugs at this moment.