Closed Bug 727950 Opened 10 years ago Closed 10 years ago

Crash in GonkCaptureProvider with sgs2 UHKI2 firmware

Categories

(Core :: Audio/Video, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: cjones, Assigned: cjones)

References

Details

Attachments

(2 files, 1 obsolete file)

STR
 (1) Open a page like
    <video id="preview" autoplay></video>
    <script>
      var uri = navigator.mozCamera.getCameraURI({ camera: 0, width: 640, height: 480});
      document.getElementById("preview").src = uri;
    </script>

Things go boom.

I'll see if a different firmware makes this go away, and if so I'll RESOLVED->OHWELL this bug.
Attached image screenshot
Works well on my S2 with a XXKI4 firmware...
on my XXKI3 it just crashed.. do I need to apply any patch first?
I tried with something close to fabrice's XXKI4 firmware, and also ZSKI3.  Both crash in the same way.
Attached patch WIP (obsolete) — Splinter Review
Makes crashy go away on akami, but we're not getting a valid camera.  Checking sgs2.
Assignee: nobody → jones.chris.g
Fixes camera on sgs2, fixes crashes on akami.
Attachment #598426 - Attachment is obsolete: true
Attachment #598467 - Flags: review?(fabrice)
Comment on attachment 598467 [details] [diff] [review]
Don't close the camera dso, some of them don't like that

Review of attachment 598467 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, feel free to keep your log or not.

::: netwerk/protocol/device/GonkCaptureProvider.cpp
@@ +44,5 @@
>  #define CameraHardwareInterface CameraHardwareInterface_DEFAULT
>  #include "camera/CameraHardwareInterface.h"
>  #undef CameraHardwareInterface
>  
> +#define LOG(args...)  __android_log_print(ANDROID_LOG_INFO, "Gonk" , ## args)

Why do you redefine LOG here? It's very similar to printf_stderr (http://mxr.mozilla.org/mozilla-central/source/xpcom/glue/nsCRTGlue.cpp#290) with Gonk instead of Gecko
Attachment #598467 - Flags: review?(fabrice) → review+
Pushed with printf_stderr change

https://hg.mozilla.org/mozilla-central/rev/550779e6bab4
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.