727950 - Crash in GonkCaptureProvider with sgs2 UHKI2 firmware

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

STR
 (1) Open a page like
    <video id="preview" autoplay></video>
    <script>
      var uri = navigator.mozCamera.getCameraURI({ camera: 0, width: 640, height: 480});
      document.getElementById("preview").src = uri;
    </script>

Things go boom.

I'll see if a different firmware makes this go away, and if so I'll RESOLVED->OHWELL this bug.

Comment 1

[[:fabrice] Fabrice Desré]

Attachment: screenshot

Works well on my S2 with a XXKI4 firmware...

Comment 2

[Kan-Ru Chen [:kanru] (UTC+9)]

on my XXKI3 it just crashed.. do I need to apply any patch first?

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

I tried with something close to fabrice's XXKI4 firmware, and also ZSKI3.  Both crash in the same way.

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: WIP

Makes crashy go away on akami, but we're not getting a valid camera.  Checking sgs2.

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Don't close the camera dso, some of them don't like that

Fixes camera on sgs2, fixes crashes on akami.

Comment 6

[[:fabrice] Fabrice Desré]

Comment on attachment 598467 [details] [diff] [review]
Don't close the camera dso, some of them don't like that

Review of attachment 598467 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, feel free to keep your log or not.

::: netwerk/protocol/device/GonkCaptureProvider.cpp
@@ +44,5 @@
>  #define CameraHardwareInterface CameraHardwareInterface_DEFAULT
>  #include "camera/CameraHardwareInterface.h"
>  #undef CameraHardwareInterface
>  
> +#define LOG(args...)  __android_log_print(ANDROID_LOG_INFO, "Gonk" , ## args)

Why do you redefine LOG here? It's very similar to printf_stderr (http://mxr.mozilla.org/mozilla-central/source/xpcom/glue/nsCRTGlue.cpp#290) with Gonk instead of Gecko

Comment 7

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Pushed with printf_stderr change

https://hg.mozilla.org/mozilla-central/rev/550779e6bab4