728056 - Rework tutorial content, part 1

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: Documentation, defect, P1)

Description

[Will Bamberg [:wbamberg]]

Attachment: Pull Request 347

Pull request #347 introduces a lot of new, and reworked, tutorial content. This bug is to ask for review of the subset of them that talk about content-script-using modules.

There's quite a lot of duplication between these tutorials, because there's a lot that's common between the modules. I thought that, rather than pointing people at a generalized introduction to content scripts, it would be easier for users (although harder for maintainers!) to duplicate content.

The files needing review for this bug are:
display-a-popup.md: https://github.com/mozilla/addon-sdk/pull/347/files#diff-22
adding-toolbar-button.md: https://github.com/mozilla/addon-sdk/pull/347/files#diff-20
adding-toolbar-content.md: https://github.com/mozilla/addon-sdk/pull/347/files#diff-21
modifying-web-pages-tab.md: https://github.com/mozilla/addon-sdk/pull/347/files#diff-28
modifying-web-pages-url.md: https://github.com/mozilla/addon-sdk/pull/347/files#diff-29

Comment 1

[Alexandre Poirot [:ochameau]]

Comment on attachment 598034 [details] [diff] [review]
Pull Request 347

Oh ... I should have read the bug comment before reviewing this ... big! pull request. So I started to review the whole patch and stoped in the middle when I finally read the bug comment!

I wrote many comments, but I don't think they need another review cycle.
Feel free to request another one if you want my feedback again.

And thanks for this awesome work, I can't stop saying how much it highlights our development efforts by helping people playing with our modules and tools!

Comment 2

[Will Bamberg [:wbamberg]]

Sorry Alex! But thanks for over-reviewing! :-)

Comment 3

[Will Bamberg [:wbamberg]]

I've commented on a few of your comments, all the rest look simple to address.

Comment 4

[Will Bamberg [:wbamberg]]

Fixed by: https://github.com/mozilla/addon-sdk/commit/4e22d237650781a42874e95d3b8f9990a83c86cb.