728101 - Global search box shrinks when selected

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Andreas Nilsson (:andreasn)]

Noticed that the search box in trunk shrinks a couple of pixels when selected.

Comment 1

[Richard Marti (:Paenglab)]

This is because in unselected state the text is italic (and wider) and when selected normal.
This can be solved by giving a fixed width to the search box, removing the italic (like in Bug 636014) or exchange the flexible spacer with fixed spacer. I'm on XP now and can't test if the last really would solve the problem.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: Give a fixed width

With defining the width the box no more jumps when selected. I gave a width of 25em. If needed this width can be adjusted.

When more elements are on the toolbar then the search box adapts the width as before.

The patch also gives a width to the search box on Address book which has the same problem.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: Give a fixed width

Patch updated after landing of Bug 719008. Now also the search field in Gloda tab shrinks.

Comment 4

[Andreas Nilsson (:andreasn)]

Comment on attachment 599679 [details] [diff] [review]
Give a fixed width

Looks good, functions as expected!

Comment 5

[Ryan VanderMeulen [:RyanVM]]

http://hg.mozilla.org/comm-central/rev/6c1d59144158

Also, please follow the directions below when submitting any future patches to make life easier for the people checking in on your behalf. Thanks!
https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F