728128 - Make behavior of the "hardware" buttons configurable

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Currently the "back" button is fired as the escape key and the home button as the home key.  We probably don't need that to be configurable.

But the menu button is dispatched to content specially (with a nonstandard DOM event), and the search button enables a special graphics debug mode.  In production phones we don't want the debug mode enable-able.  And we'll want to remap the menu button to "view-source" for Gaia.

So all this should be configurable.  Prefs seem ok.  A magical button-layout.json alongside homescreen.html, read by the chrome package on startup, is another option.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

The patch add 2 preferences:
 b2g.keys.menu.enabled (true by default)
 b2g.keys.search.enabled (false by default)

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Can you land this soon?  Our friends are eagerly awaiting it.  I can if you're not.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Chris Jones [:cjones] [:warhammer] from comment #2)
> Can you land this soon?  Our friends are eagerly awaiting it.  I can if
> you're not.

I will land it in a few minutes if possible.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Vivien Nicolas (:vingtetun) from comment #3)
> (In reply to Chris Jones [:cjones] [:warhammer] from comment #2)
> > Can you land this soon?  Our friends are eagerly awaiting it.  I can if
> > you're not.
> 
> I will land it in a few minutes if possible.

Hum. By landing do you mean git-mc? If so I probably do to need a branch first, that will take some times.

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Straight to upstream m-c is fine.

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/16283b69a10a

Comment 7

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/16283b69a10a