728132 - test_bug583533.html uses wrong const values

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

test_bug583533.html uses nsIDOMNSEvent::META_MASK, nsIDOMNSEvent::CONTROL_MASK, nsIDOMNSEvent::ALT_MASK and nsIDOMNSEvent::SHIFT_MASK.

However, the pref's value isn't same as them. The values for Alt and Shift are different.

http://mxr.mozilla.org/mozilla-central/source/content/events/src/nsEventStateManager.cpp#292
293 #define NS_MODIFIER_SHIFT    1
294 #define NS_MODIFIER_CONTROL  2
295 #define NS_MODIFIER_ALT      4
296 #define NS_MODIFIER_META     8

http://mxr.mozilla.org/mozilla-central/source/dom/interfaces/events/nsIDOMNSEvent.idl#82
82   const long ALT_MASK     = 0x00000001;
83   const long CONTROL_MASK = 0x00000002;
84   const long SHIFT_MASK   = 0x00000004;
85   const long META_MASK    = 0x00000008;

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

dzbarsky: ping

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 598157 [details] [diff] [review]
Patch

Smaug;

Would your review this? I cannot contact dzbarsky yet...

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 598157 [details] [diff] [review]
Patch

Well, if the test does still pass...

We should probably change ESM consts at some point.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/72cb7e2287ba

> We should probably change ESM consts at some point.

The ESM's value is documented in all.js and mozillazine introduced the information.
http://kb.mozillazine.org/Ui.key.contentAccess

We shouldn't change the value.

Comment 6

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/72cb7e2287ba

Comment 7

[Firefox Bug Husbandry Bot]

Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336