Closed Bug 728132 Opened 11 years ago Closed 11 years ago

test_bug583533.html uses wrong const values

Categories

(Core :: XUL, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

Attachments

(1 file)

test_bug583533.html uses nsIDOMNSEvent::META_MASK, nsIDOMNSEvent::CONTROL_MASK, nsIDOMNSEvent::ALT_MASK and nsIDOMNSEvent::SHIFT_MASK.

However, the pref's value isn't same as them. The values for Alt and Shift are different.

http://mxr.mozilla.org/mozilla-central/source/content/events/src/nsEventStateManager.cpp#292
293 #define NS_MODIFIER_SHIFT    1
294 #define NS_MODIFIER_CONTROL  2
295 #define NS_MODIFIER_ALT      4
296 #define NS_MODIFIER_META     8

http://mxr.mozilla.org/mozilla-central/source/dom/interfaces/events/nsIDOMNSEvent.idl#82
82   const long ALT_MASK     = 0x00000001;
83   const long CONTROL_MASK = 0x00000002;
84   const long SHIFT_MASK   = 0x00000004;
85   const long META_MASK    = 0x00000008;
Attached patch PatchSplinter Review
Attachment #598157 - Flags: review?(dzbarsky)
dzbarsky: ping
Comment on attachment 598157 [details] [diff] [review]
Patch

Smaug;

Would your review this? I cannot contact dzbarsky yet...
Attachment #598157 - Flags: review?(bugs)
Comment on attachment 598157 [details] [diff] [review]
Patch

Well, if the test does still pass...

We should probably change ESM consts at some point.
Attachment #598157 - Flags: review?(bugs) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/72cb7e2287ba

> We should probably change ESM consts at some point.

The ESM's value is documented in all.js and mozillazine introduced the information.
http://kb.mozillazine.org/Ui.key.contentAccess

We shouldn't change the value.
Whiteboard: [inbound]
Target Milestone: --- → mozilla13
Attachment #598157 - Flags: review?(dzbarsky)
https://hg.mozilla.org/mozilla-central/rev/72cb7e2287ba
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336
Component: XP Toolkit/Widgets: XUL → XUL
You need to log in before you can comment on or make changes to this bug.