728229 - Allow to build with system python ply library

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Allow to build with system python ply library

Comment 2

[Benjamin Smedberg]

Why? ply hasn't been terribly stable (or we relied on undocumented behavior) and so I'm a bit skeptical that this is something we want to do.

Comment 3

[Mike Hommey [:glandium]]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #2)
> Why? ply hasn't been terribly stable (or we relied on undocumented behavior)
> and so I'm a bit skeptical that this is something we want to do.

Because I don't want to ship ply with the sdk on debian. I've also been using system ply to build seamonkey for a whole while now and haven't had any problems with that.

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 598241 [details] [diff] [review]
Allow to build with system python ply library

Review of attachment 598241 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not sure I'm wild about the concept either, but the execution here is fine. Is it really onerous to have a couple of extra Python files in our SDK?

Comment 5

[Mike Hommey [:glandium]]

(In reply to Ted Mielczarek [:ted] (away until ~March 7) from comment #4)
> I'm not sure I'm wild about the concept either, but the execution here is
> fine. Is it really onerous to have a couple of extra Python files in our SDK?

We prefer to avoid useless duplicates, in debian. Not this is not meant to be used on Mozilla builds.

Comment 6

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a4bd10f72128

Comment 7

[Richard Newman [:rnewman]]

https://hg.mozilla.org/mozilla-central/rev/a4bd10f72128