Closed
Bug 728290
Opened 12 years ago
Closed 12 years ago
IonMonkey: Compile JSOP_NEWOBJECT
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
10.50 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
2.98 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
Blocks Kraken audio-dft and v8-splay.
Assignee | ||
Updated•12 years ago
|
Assignee: general → jdemooij
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #600363 -
Flags: review?(dvander)
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #600364 -
Flags: review?(dvander)
Updated•12 years ago
|
Attachment #600363 -
Flags: review?(dvander) → review+
Comment on attachment 600364 [details] [diff] [review] Part 2: Compile JSOP_INITPROP Review of attachment 600364 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/ion/IonBuilder.cpp @@ +2673,5 @@ > + MDefinition *value = current->pop(); > + MDefinition *obj = current->peek(-1); > + > + JSObject *baseObj = obj->toNewObject()->baseObj(); > + JS_ASSERT(baseObj); No assert needed here, if it's NULL we'll crash pretty quickly.
Attachment #600364 -
Flags: review?(dvander) → review+
Assignee | ||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/projects/ionmonkey/rev/7fc13fbbc330 https://hg.mozilla.org/projects/ionmonkey/rev/abb6b44448af
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•