Closed Bug 728290 Opened 10 years ago Closed 10 years ago

IonMonkey: Compile JSOP_NEWOBJECT

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jandem, Assigned: jandem)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Blocks Kraken audio-dft and v8-splay.
Assignee: general → jdemooij
Status: NEW → ASSIGNED
Attachment #600363 - Flags: review?(dvander)
Attachment #600364 - Flags: review?(dvander)
Attachment #600363 - Flags: review?(dvander) → review+
Comment on attachment 600364 [details] [diff] [review]
Part 2: Compile JSOP_INITPROP

Review of attachment 600364 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/IonBuilder.cpp
@@ +2673,5 @@
> +    MDefinition *value = current->pop();
> +    MDefinition *obj = current->peek(-1);
> +
> +    JSObject *baseObj = obj->toNewObject()->baseObj();
> +    JS_ASSERT(baseObj);

No assert needed here, if it's NULL we'll crash pretty quickly.
Attachment #600364 - Flags: review?(dvander) → review+
https://hg.mozilla.org/projects/ionmonkey/rev/7fc13fbbc330
https://hg.mozilla.org/projects/ionmonkey/rev/abb6b44448af
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.