7283 - Oddity in EventQueueEntry definition/declaration

Status: VERIFIED INVALID

(Core :: XPCOM, defect, P2)

Description

[Bruce Mitchener]

In xpcom/threads/nsEventQueueService.cpp there is this:

/* nsISupports interface implementation... */
NS_IMPL_ISUPPORTS(EventQueueEntry,nsISupports::GetIID());

(depending on when look, it might be using kISupportsIID instead of
nsISupports::GetIID().  Either way, why is this implementing a QueryInterface
for nsISupports rather than one for EventQueueEntry?

Comment 1

[Bruce Mitchener]

Btw, the reason I might have changed the kISupportsIID to nsISupports::GetIID()
is that I'm working on removing the kISupportsIID static declaration from the
default implementation of QueryInterface, and this made an error with
kISupportsIID not being defined here.  (Just an FYI on the change.)

Comment 2

[Suresh Duddi (gone)]

Good point. Will fix it.

Comment 3

[Suresh Duddi (gone)]

Well nsISupports is right as it is using nsISupport not to implement an
interface but to do refcounting. Interesting...

Comment 4

[Bruce Mitchener]

Okay, then I will go and apply the patch that I have on #7284 to change this to
nsISupports::GetIID() when the rest of the patches get applied.  Thanks!

Comment 5

[Jay Patel [:jay]]

Verified Invalid