Oddity in EventQueueEntry definition/declaration

VERIFIED INVALID

Status

()

Core
XPCOM
P2
major
VERIFIED INVALID
19 years ago
19 years ago

People

(Reporter: Bruce Mitchener, Assigned: Suresh Duddi (gone))

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

19 years ago
In xpcom/threads/nsEventQueueService.cpp there is this:

/* nsISupports interface implementation... */
NS_IMPL_ISUPPORTS(EventQueueEntry,nsISupports::GetIID());

(depending on when look, it might be using kISupportsIID instead of
nsISupports::GetIID().  Either way, why is this implementing a QueryInterface
for nsISupports rather than one for EventQueueEntry?
(Reporter)

Comment 1

19 years ago
Btw, the reason I might have changed the kISupportsIID to nsISupports::GetIID()
is that I'm working on removing the kISupportsIID static declaration from the
default implementation of QueryInterface, and this made an error with
kISupportsIID not being defined here.  (Just an FYI on the change.)
(Assignee)

Updated

19 years ago
Severity: normal → major
Status: NEW → ASSIGNED
Priority: P3 → P2
Target Milestone: M7
(Assignee)

Comment 2

19 years ago
Good point. Will fix it.
(Assignee)

Comment 3

19 years ago
Well nsISupports is right as it is using nsISupport not to implement an
interface but to do refcounting. Interesting...
Status: ASSIGNED → RESOLVED
Last Resolved: 19 years ago
Resolution: --- → INVALID
(Reporter)

Comment 4

19 years ago
Okay, then I will go and apply the patch that I have on #7284 to change this to
nsISupports::GetIID() when the rest of the patches get applied.  Thanks!

Updated

19 years ago
Status: RESOLVED → VERIFIED

Comment 5

19 years ago
Verified Invalid
You need to log in before you can comment on or make changes to this bug.