72841 - Solaris Intel code should really be in separate files.

Status: VERIFIED FIXED

(Core :: XPConnect, defect, P3)

Description

[Rich Burridge]

[Note that this is for Solaris Intel platform only].

Comments from the Sun compiler group.

Re: xptcinvoke_unixish_x86.cpp and xptcstubs_unixish_x86.cpp

While I was looking at these to generate diffs of changes,
I thought if it will be better to have separate files
for Solaris x86, i.e. creating xptcinvoke_solaris_x86.cpp
and xptcstubs_solaris_x86.cpp. That seems to be the rule
for all other OS-processor combinations to which mozilla
is ported.
_unixish_x86 is a catchall for the set of all other x86
unices, with Solaris as the only member (currently).

Isolating Solaris x86 code in separate files will
shield it from possible future x86 ports, e.g. FreeBSD.

----

Opening a bug to adjust this after Mozilla 1.0.

Comment 1

[Rich Burridge]

Reassigning to shaver. We will supply a patch.

Comment 2

[Rich Burridge]

After chatting with shaver, have adjusted to target milestone 0.9.

Comment 3

[Rich Burridge]

Attachment: Patch to separate the Solaris Intel asm out into two separate files.

Comment 4

[Rich Burridge]

Diffs attached to separate the Solaris Intel code out into two separate
files (removing the equivalent from ..._unixish_x86.cpp. The Makefile.in
has been adjust to pick up the Solaris Intel files on that platform.
shaver, this look okay to you? Thanks.

Comment 5

[Mike Shaver (:shaver emeritus)]

There's no reason the new files should be under the NPL, I don't think: can you
have them use the MPL?  Have you tested that both Solaris/x86 and Linux/x86 can
run the xptcall tests with this patch?

Comment 6

[Rich Burridge]

Attachment: Adjusted the two new files to use the MPL rather than the NPL.

Comment 7

[Christopher Blizzard (:blizzard)]

OK, I tested this and it works for me.  Tests seem to pass, too.

Comment 8

[Rich Burridge]

shaver, hopefully we've fulfilled your two requests. Looking for an r=
from you. Thanks.

Comment 9

[Mike Shaver (:shaver emeritus)]

+ * The Initial Developer of this code under the MPL is Netscape
+ * Communications Corporation.  Portions created by Netscape are
+ * Copyright (C) 1999 Netscape Communications Corporation.  All Rights
+ * Reserved.

Is Netscape really the Initial Developer?  I would think it'd be Sun.

If so, please fix that, and then sr=shaver (enough to check in).

Comment 10

[Rich Burridge]

From looking at:
http://lxr.mozilla.org/seamonkey/source/xpcom/reflect/xptcall/status.html
it looks like John Bandhauer ([e-mail]), was the original author
of the Linux x86 version, from which are code was derived. As per our
conversation on IRC, I'll leave this the way it currently is. Thanks.

Comment 11

[Rich Burridge]

Fix checked in.

Comment 12

[Phil Schwartau]

Verified -