728422 - split search view into separate sphinx and elasticsearch versions

Status: RESOLVED FIXED

(support.mozilla.org :: Search, defect, P1)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

Currently we have one search view and in the code we take great pains to make sure it works for both Sphinx and Elastic Search.

This bug is for changing that situation. We'll create separate Sphinx and Elastic Search views and a search view that routes between the two based on the waffle.

This allows us:

1. to untangle the mild mess we have currently--right now it's hard to make changes because of the tangling

2. take advantage of ES properties, and in doing so speed the ES side up

3. add functionality to ES searches that doesn't currently exist in the Sphinx side


Putting this in the next sprint. We should do it sooner rather than later.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

We could make this a 1 pointer that just splits the code into two versions, but I think it's worth turning it into a 2 pointer and spending some time to undo some of the weirdo stuff to get ES working in the same code path as Sphinx since that should speed things up a bit and it'll require a reindexing--best to get as many of the reindexing-required changes done before we ditch Sphinx.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

This should block bug #729688.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Making this a P1 for the next sprint.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Grabbing these.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

In a pull request: https://github.com/mozilla/kitsune/pull/534

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

Landed in master in https://github.com/mozilla/kitsune/commit/7f753ff91432fdcf51b6648d655e6c24c3f01961

Deployed today.