728462 - GCC build warning: nsPresShell.cpp:691:15: warning: ‘size_t GfxTextrunWordCacheMallocSizeOf(const void*)’ defined but not used

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Daniel Holbert [:dholbert]]

nsPresShell.cpp:691:15: warning: ‘size_t GfxTextrunWordCacheMallocSizeOf(const void*)’ defined but not used [-Wunused-function]

This is defined here:
691 NS_MEMORY_REPORTER_MALLOC_SIZEOF_FUN(GfxTextrunWordCacheMallocSizeOf, "gfx/textrun-word-cache")
http://mxr.mozilla.org/mozilla-central/source/layout/base/nsPresShell.cpp#691

There was only ever one use of this variable, and it was removed here in bug 703100:
  http://hg.mozilla.org/mozilla-central/rev/05fff11a2781

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 598416 [details] [diff] [review]
fix

oops, this got some unrelated work included. fixed patch coming up.

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 4

[Jonathan Kew [:jfkthame]]

Comment on attachment 598421 [details] [diff] [review]
fix

Review of attachment 598421 [details] [diff] [review]:
-----------------------------------------------------------------

Yup, that's obsolete. Kill it.

Comment 5

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2742dd95aa74

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2742dd95aa74