Closed
Bug 728516
Opened 9 years ago
Closed 9 years ago
Refactor frame construction for things that want to wrap kids in a block into a common codepath
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file, 1 obsolete file)
30.71 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
Buttons, foreignObject, and soon maybe canvas all want to do this. Upcoming patch refactors things to put it behind a singe fcdata flag. The other option is to use a single full-constructor method for all of these and keep the complexity out of ConstructFrameFromItemInternal, but the full-constructor would end up with a bunch more code in it, I suspect...
![]() |
Assignee | |
Comment 1•9 years ago
|
||
Robert, if you don't think you can comfortably get to this before your trip, just punt to Timothy, ok?
Attachment #598481 -
Flags: review?(roc)
![]() |
Assignee | |
Comment 2•9 years ago
|
||
Attachment #598498 -
Flags: review?(roc)
![]() |
Assignee | |
Updated•9 years ago
|
Attachment #598481 -
Attachment is obsolete: true
Attachment #598481 -
Flags: review?(roc)
Attachment #598498 -
Flags: review?(roc) → review+
![]() |
Assignee | |
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb6e8ee380fe
Flags: in-testsuite-
Target Milestone: --- → mozilla13
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fb6e8ee380fe
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•