728636 - Conversion of email address to account should lowercase

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Android Sync, defect, P2)

Description

[Richard Newman [:rnewman]]

We only lowercase the output.

    public static String usernameFromAccount(String account) throws NoSuchAlgorithmException, UnsupportedEncodingException {
      if (account == null || account.equals("")) {
        throw new IllegalArgumentException("No account name provided.");
      }
      if (account.matches("^[A-Za-z0-9._-]+$")) {
        return account;
      }
      return Utils.sha1Base32(account);
    }

  public static byte[] sha1(String utf8)
      throws NoSuchAlgorithmException, UnsupportedEncodingException {
    MessageDigest sha1 = MessageDigest.getInstance("SHA-1");
    return sha1.digest(utf8.getBytes("UTF-8"));
  }

  public static String sha1Base32(String utf8)
      throws NoSuchAlgorithmException, UnsupportedEncodingException {
    return new Base32().encodeAsString(sha1(utf8)).toLowerCase();
  }

This, of course, will b0rk setup for anyone who capitalizes their email address (or whose Android keyboard does it for them).

Comment 1

[Richard Newman [:rnewman]]

https://github.com/mozilla-services/android-sync/pull/76

Comment 2

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/08df8cb41dfd

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/08df8cb41dfd