728661 - Remove CalcVectorAngle and use AngleOfVector instead.

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Cameron McCormack (:heycam)]

We can replace uses of CalcVectorAngle in SVGPathData.cpp with AngleOfVector,
as comments in the file suggest.

Comment 1

[Cameron McCormack (:heycam)]

Attachment: Remove CalcVectorAngle and use AngleOfVector instead.

Comment 2

[Robert Longson [:longsonr]]

Since you're changing this... Wouldn't it also be better if AngleOfVector took a const reference rather than passing by value?

Comment 3

[Cameron McCormack (:heycam)]

Attachment: Remove CalcVectorAngle and use AngleOfVector instead. (v1.1)

Yes, good idea.

Comment 4

[Cameron McCormack (:heycam)]

Attachment: Remove CalcVectorAngle and use AngleOfVector instead. (v1.1)

Yes, good idea.

Comment 5

[Jonathan Watt [:jwatt]]

Comment on attachment 598646 [details] [diff] [review]
Remove CalcVectorAngle and use AngleOfVector instead.

Seems like this is going to turn one "conversion from double to float looses precision" warning into lots of similar warnings at all the existing AngleOfVector call points. It may be better to have a second function AngleOfVectorAsFloat that does |return float(AngleOfVector(v))|.

Comment 6

[Cameron McCormack (:heycam)]

OK, I'll look into silencing the warnings with something like that.

Comment 7

[Cameron McCormack (:heycam)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/766fdf473acd

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/766fdf473acd