Error: document.getElementById("sep-window-list") is null

RESOLVED FIXED in Thunderbird 27.0

Status

RESOLVED FIXED
7 years ago
5 years ago

People

(Reporter: Nomis101, Assigned: aceman)

Tracking

11 Branch
Thunderbird 27.0
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

2.61 KB, patch
bwinton
: review+
Nomis101
: feedback+
Details | Diff | Splinter Review
(Reporter)

Description

7 years ago
In the error console in Thunderbird 11 I see:

Error: document.getElementById("sep-window-list") is null
Source File: chrome://messenger/content/hiddenWindow.js
Line: 46
(Assignee)

Comment 1

7 years ago
I think I have seen this somewhere. Can you tell what you were doing when the error comes up? Does it happen in TB13?
(Reporter)

Comment 2

7 years ago
(In reply to :aceman from comment #1)
> Can you tell what you were doing when
> the error comes up? 
Nothing specific, I have this everytime. If you want some STR, than: Start Thunderbird --> Open the error console

(In reply to :aceman from comment #1)
> Does it happen in TB13?
Yes, I also see it in the latest nightly.
(Assignee)

Comment 3

6 years ago
I still can't see it anywhere. Does it still happen? Have you tried Thunderbird's Safe mode?
(Assignee)

Comment 4

6 years ago
Try Help->Restart with addons disabled.
(Assignee)

Comment 5

5 years ago
Ok, that element seems to be defined only /mozilla/toolkit/content/macWindowMenu.inc and is being overlaid on Mac.

http://mxr.mozilla.org/comm-central/search?string=sep-window-list&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central

At http://mxr.mozilla.org/comm-central/source/mozilla/browser/base/content/browser.js#1463 the attribute setting is dependent on being on Mac OS X.

In Seamonkey at http://mxr.mozilla.org/comm-central/source/suite/browser/navigator.js#1915 they set the attribute only if the element exists. So do the same in TB.
Assignee: nobody → acelists
Status: NEW → ASSIGNED
(Assignee)

Comment 6

5 years ago
Created attachment 789178 [details] [diff] [review]
patch

So actually I should have seen the error on linux but I have not. Nomis101 filed it under Mac where I would expect the element to exist so no error should be produced. Strange. I'd like somebody with a Mac to check this out.
Attachment #789178 - Flags: review?(bwinton)
Attachment #789178 - Flags: feedback?(Nomis101)
(Reporter)

Comment 7

5 years ago
I have no problem with your patch, no new error or whatsoever. But, I have checked and I don't see the reported error anymore in TB 23 and higher.
(Reporter)

Updated

5 years ago
Attachment #789178 - Flags: feedback?(Nomis101) → feedback+
(Assignee)

Comment 8

5 years ago
Comment on attachment 789178 [details] [diff] [review]
patch

Josiah, are you able to check this out on Mac?
Attachment #789178 - Flags: feedback?(josiah)
(In reply to :aceman from comment #8)
> Comment on attachment 789178 [details] [diff] [review]
> patch
> 
> Josiah, are you able to check this out on Mac?

I'm not seeing the error at all in the error console on OS X. So I can't really say if your patch it working.
Comment on attachment 789178 [details] [diff] [review]
patch

Review of attachment 789178 [details] [diff] [review]:
-----------------------------------------------------------------

Clearing review flag until more info is given on how to reproduce the error (If even possible).
Attachment #789178 - Flags: feedback?(josiah)
Comment on attachment 789178 [details] [diff] [review]
patch

Yeah, I can see how that happened.

The m-c version (at http://mxr.mozilla.org/comm-central/source/mozilla/browser/base/content/browser.js#1388 ) is wrapped in an "#ifdef XP_MACOSX" (at http://mxr.mozilla.org/comm-central/source/mozilla/browser/base/content/browser.js#1357 )

The rest of the cleanup is unnecessary, but seems harmless, so r=me.  ;)

Thanks,
Blake.
Attachment #789178 - Flags: review?(bwinton) → review+
(Assignee)

Comment 12

5 years ago
Thanks!
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/fa422ca68f08
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 27.0
You need to log in before you can comment on or make changes to this bug.