Closed Bug 728780 Opened 10 years ago Closed 10 years ago

Define String.prototype.startsWith and use it in about:memory

Categories

(Toolkit :: about:memory, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: n.nethercote, Assigned: n.nethercote)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
jlebar suggested creating String.prototype.startsWith, and bug 722972 comment 29 Neil suggested an efficient implementation.  Let's do it!
Attachment #598766 - Flags: review?(jschoenick)
Wrong patch?
Mmm, yes.  And the machine the right patch is on is turned off for the night.  I'll try again tomorrow!
Summary: Defined String.prototype.startsWith and use it in about:memory → Define String.prototype.startsWith and use it in about:memory
Attached patch the right patchSplinter Review
Attachment #598766 - Attachment is obsolete: true
Attachment #598955 - Flags: review?
Attachment #598766 - Flags: review?(jschoenick)
Attachment #598955 - Flags: review? → review?(jschoenick)
Comment on attachment 598955 [details] [diff] [review]
the right patch

Review of attachment 598955 [details] [diff] [review]:
-----------------------------------------------------------------

That is a clever trick!

Looks good
Attachment #598955 - Flags: review?(jschoenick) → review+
Thanks for the fast review, John!
https://hg.mozilla.org/mozilla-central/rev/621528be5df8
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.