Closed
Bug 728780
Opened 12 years ago
Closed 12 years ago
Define String.prototype.startsWith and use it in about:memory
Categories
(Toolkit :: about:memory, defect)
Toolkit
about:memory
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
Attachments
(1 file, 1 obsolete file)
|
4.28 KB,
patch
|
johns
:
review+
|
Details | Diff | Splinter Review |
jlebar suggested creating String.prototype.startsWith, and bug 722972 comment 29 Neil suggested an efficient implementation. Let's do it!
Attachment #598766 -
Flags: review?(jschoenick)
|
||
Comment 1•12 years ago
|
||
Wrong patch?
|
Assignee | |
Comment 2•12 years ago
|
||
Mmm, yes. And the machine the right patch is on is turned off for the night. I'll try again tomorrow!
|
|
Assignee | |
Updated•12 years ago
|
Summary: Defined String.prototype.startsWith and use it in about:memory → Define String.prototype.startsWith and use it in about:memory
|
|
Assignee | |
Comment 3•12 years ago
|
||
Attachment #598766 -
Attachment is obsolete: true
Attachment #598955 -
Flags: review?
Attachment #598766 -
Flags: review?(jschoenick)
|
|
Assignee | |
Updated•12 years ago
|
Attachment #598955 -
Flags: review? → review?(jschoenick)
|
||
Comment 4•12 years ago
|
||
Comment on attachment 598955 [details] [diff] [review] the right patch Review of attachment 598955 [details] [diff] [review]: ----------------------------------------------------------------- That is a clever trick! Looks good
Attachment #598955 -
Flags: review?(jschoenick) → review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
Thanks for the fast review, John!
|
||
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/621528be5df8
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in
before you can comment on or make changes to this bug.
Description
•