Closed Bug 728897 Opened 11 years ago Closed 11 years ago

"Search All Messages" should be just "Search"

Categories

(Thunderbird :: Mail Window Front End, defect)

Product:
Thunderbird
Component:
Mail Window Front End
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird11+ fixed, thunderbird12+ fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 13.0
Tracking Flags:
Tracking Status
thunderbird11 + fixed
thunderbird12 + fixed

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(2 files, 1 obsolete file)

Branch patch
909 bytes, patch
bwinton
: review+
bwinton
: ui-review+
standard8
: approval-comm-aurora+
standard8
: approval-comm-beta+
Details | Diff | Splinter Review
The fix v2
3.84 KB, patch
bwinton
: review+
bwinton
: ui-review+
Details | Diff | Splinter Review 
In the Global Search bar, "Search All Messages" should just be "Search" now that we have the capability to do web search in there, and new features may add search for other things to that list.
So how will users know what exactly will be searched?
It is the global search for a reason, but specifically the search the web option lists it in the autocomplete list.
Assignee: nobody → acelists
How do we all feel about "Search Everything" instead?
Attached patch The fix (obsolete) — — Splinter Review 
Just using Search as previously agreed.
Assignee: acelists → mbanner
Status: NEW → ASSIGNED
Attachment #601036 - Flags: ui-review?(bwinton)
Attachment #601036 - Flags: review?(bwinton)
Comment on attachment 601036 [details] [diff] [review]
The fix

That was a much larger change than I would have guessed…

ui-r=me, and r=me.

Thanks,
Blake.
Attachment #601036 - Flags: ui-review?(bwinton)
Attachment #601036 - Flags: ui-review+
Attachment #601036 - Flags: review?(bwinton)
Attachment #601036 - Flags: review+
Attached patch Branch patch — — Splinter Review 
Branch patch. This is so that we can change en-US without affecting locales, although locales can pick it up if they want.

"Search All Messages" is reasonable, but now we've got searching the web from that menu as well, we've had feedback that "Search" would be clearer, so we'd like to start pushing that out as soon as we can.
Attachment #601047 - Flags: ui-review?(bwinton)
Attachment #601047 - Flags: review?(bwinton)
Comment on attachment 601047 [details] [diff] [review]
Branch patch

That's much smaller.  ui-rs=me, rs=me.
Attachment #601047 - Flags: ui-review?(bwinton)
Attachment #601047 - Flags: ui-review+
Attachment #601047 - Flags: review?(bwinton)
Attachment #601047 - Flags: review+
Attached patch The fix v2 — — Splinter Review 
Ok, I realised I should have gone with just renaming the string label as "searchAllMessages" doesn't apply for L10n either now.
Attachment #601036 - Attachment is obsolete: true
Attachment #601048 - Flags: ui-review?(bwinton)
Attachment #601048 - Flags: review?(bwinton)
Comment on attachment 601048 [details] [diff] [review]
The fix v2

That looks better.  ui-r=me, r=me.
Attachment #601048 - Flags: ui-review?(bwinton)
Attachment #601048 - Flags: ui-review+
Attachment #601048 - Flags: review?(bwinton)
Attachment #601048 - Flags: review+
Checked in:

http://hg.mozilla.org/comm-central/rev/201ebae0fa47
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
tracking-thunderbird11: --- → +
tracking-thunderbird12: --- → +
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 13.0
Comment on attachment 601047 [details] [diff] [review]
Branch patch

[Triage Comment]
Attachment #601047 - Flags: approval-comm-beta+
Attachment #601047 - Flags: approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.