"Search All Messages" should be just "Search"

RESOLVED FIXED in Thunderbird 13.0

Status

Thunderbird
Mail Window Front End
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Trunk
Thunderbird 13.0

Thunderbird Tracking Flags

(thunderbird11+ fixed, thunderbird12+ fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

5 years ago
In the Global Search bar, "Search All Messages" should just be "Search" now that we have the capability to do web search in there, and new features may add search for other things to that list.

Comment 1

5 years ago
So how will users know what exactly will be searched?
(Assignee)

Comment 2

5 years ago
It is the global search for a reason, but specifically the search the web option lists it in the autocomplete list.

Updated

5 years ago
Assignee: nobody → acelists
How do we all feel about "Search Everything" instead?
(Assignee)

Comment 4

5 years ago
Created attachment 601036 [details] [diff] [review]
The fix

Just using Search as previously agreed.
Assignee: acelists → mbanner
Status: NEW → ASSIGNED
Attachment #601036 - Flags: ui-review?(bwinton)
Attachment #601036 - Flags: review?(bwinton)
Comment on attachment 601036 [details] [diff] [review]
The fix

That was a much larger change than I would have guessed…

ui-r=me, and r=me.

Thanks,
Blake.
Attachment #601036 - Flags: ui-review?(bwinton)
Attachment #601036 - Flags: ui-review+
Attachment #601036 - Flags: review?(bwinton)
Attachment #601036 - Flags: review+
(Assignee)

Comment 6

5 years ago
Created attachment 601047 [details] [diff] [review]
Branch patch

Branch patch. This is so that we can change en-US without affecting locales, although locales can pick it up if they want.

"Search All Messages" is reasonable, but now we've got searching the web from that menu as well, we've had feedback that "Search" would be clearer, so we'd like to start pushing that out as soon as we can.
Attachment #601047 - Flags: ui-review?(bwinton)
Attachment #601047 - Flags: review?(bwinton)
Comment on attachment 601047 [details] [diff] [review]
Branch patch

That's much smaller.  ui-rs=me, rs=me.
Attachment #601047 - Flags: ui-review?(bwinton)
Attachment #601047 - Flags: ui-review+
Attachment #601047 - Flags: review?(bwinton)
Attachment #601047 - Flags: review+
(Assignee)

Comment 8

5 years ago
Created attachment 601048 [details] [diff] [review]
The fix v2

Ok, I realised I should have gone with just renaming the string label as "searchAllMessages" doesn't apply for L10n either now.
Attachment #601036 - Attachment is obsolete: true
Attachment #601048 - Flags: ui-review?(bwinton)
Attachment #601048 - Flags: review?(bwinton)
Comment on attachment 601048 [details] [diff] [review]
The fix v2

That looks better.  ui-r=me, r=me.
Attachment #601048 - Flags: ui-review?(bwinton)
Attachment #601048 - Flags: ui-review+
Attachment #601048 - Flags: review?(bwinton)
Attachment #601048 - Flags: review+
(Assignee)

Comment 10

5 years ago
Checked in:

http://hg.mozilla.org/comm-central/rev/201ebae0fa47
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
tracking-thunderbird11: --- → +
tracking-thunderbird12: --- → +
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 13.0
(Assignee)

Comment 11

5 years ago
Comment on attachment 601047 [details] [diff] [review]
Branch patch

[Triage Comment]
Attachment #601047 - Flags: approval-comm-beta+
Attachment #601047 - Flags: approval-comm-aurora+
(Assignee)

Comment 12

5 years ago
Checked into branches:

http://hg.mozilla.org/releases/comm-aurora/rev/546853a06b44
http://hg.mozilla.org/releases/comm-beta/rev/fc6a980bc93b
status-thunderbird11: --- → fixed
status-thunderbird12: --- → fixed
You need to log in before you can comment on or make changes to this bug.