728911 - Remove nsBlockFrame::mBullet and store it in a frame property instead (as needed)

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, defect)

Description

[Mats Palmgren (inactive)]

This is mostly to support GetChildList() returning const nsFrameList&,
but I think it's a nice memory win as well since blocks only rarely
have a bullet.

Comment 1

[Mats Palmgren (inactive)]

Attachment: part 1, minor cleanup

Add a HasPushedFloat() method and move the PushedFloatProperty declaration to the .cpp file.

Comment 2

[Mats Palmgren (inactive)]

Attachment: part 2, bullet properties

Remove the nsBlockFrame::mBullet member and store it in a frame property instead
(as needed).  For an outside bullet, store it as a nsFrameList* to support
GetChildList(kBulletList).  For an inside bullet, store it as frame pointer.
Use separate frame properties, mutually exclusive.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 598904 [details] [diff] [review]
part 1, minor cleanup

r=me

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 598907 [details] [diff] [review]
part 2, bullet properties

r=me

Comment 5

[Mats Palmgren (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3f8c3a825d01
https://hg.mozilla.org/integration/mozilla-inbound/rev/b0f4734dba3c

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b0f4734dba3c
https://hg.mozilla.org/mozilla-central/rev/3f8c3a825d01