Remove nsBlockFrame::mBullet and store it in a frame property instead (as needed)

RESOLVED FIXED in mozilla13

Status

()

defect
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: mats, Assigned: mats)

Tracking

unspecified
mozilla13
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(2 attachments)

This is mostly to support GetChildList() returning const nsFrameList&,
but I think it's a nice memory win as well since blocks only rarely
have a bullet.
Add a HasPushedFloat() method and move the PushedFloatProperty declaration to the .cpp file.
Attachment #598904 - Flags: review?(bzbarsky)
Remove the nsBlockFrame::mBullet member and store it in a frame property instead
(as needed).  For an outside bullet, store it as a nsFrameList* to support
GetChildList(kBulletList).  For an inside bullet, store it as frame pointer.
Use separate frame properties, mutually exclusive.
Attachment #598907 - Flags: review?(bzbarsky)
Comment on attachment 598904 [details] [diff] [review]
part 1, minor cleanup

r=me
Attachment #598904 - Flags: review?(bzbarsky) → review+
Comment on attachment 598907 [details] [diff] [review]
part 2, bullet properties

r=me
Attachment #598907 - Flags: review?(bzbarsky) → review+
You need to log in before you can comment on or make changes to this bug.