728919 - [patch] Fix clang warning in sslcon.c

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[thakis]

Attachment: nss-sslcon.patch

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_6_8) AppleWebKit/535.20 (KHTML, like Gecko) Chrome/19.0.1036.7 Safari/535.20

Steps to reproduce:

I compiled sslcon.c with clang.


Actual results:

../../net/third_party/nss/ssl/sslcon.c:1443:24: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
    if((ss->sec.ci.sid == 0))
        ~~~~~~~~~~~~~~~^~~~
../../net/third_party/nss/ssl/sslcon.c:1443:24: note: remove extraneous parentheses around the comparison to silence this warning
    if((ss->sec.ci.sid == 0))
       ~               ^   ~
../../net/third_party/nss/ssl/sslcon.c:1443:24: note: use '=' to turn this equality comparison into an assignment
    if((ss->sec.ci.sid == 0))
                       ^~



Expected results:

No warning.

Comment 1

[Wan-Teh Chang]

Thank you for the patch.  That line originally read:

    if((ss->sec == 0) || (ss->sec->ci.sid == 0))

The extra parentheses were necessary to silence another gcc warning.
When the first test in the expression was removed, the extra parentheses
weren't removed.

Patch checked in on the NSS trunk (NSS 3.13.4).

Checking in sslcon.c;
/cvsroot/mozilla/security/nss/lib/ssl/sslcon.c,v  <--  sslcon.c
new revision: 1.46; previous revision: 1.45
done