Closed Bug 728932 Opened 11 years ago Closed 11 years ago

nsBrowserContentHandler's needHomepageOverride should use nsIXULAppInfo::platformVersion instead of nsIHttpProtocolHandler::misc

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 13

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

patch
1.40 KB, patch
Gavin
: review+
Details | Diff | Splinter Review 
The first nightly after bug 572659 spawned the first run page due to needHomepageOverride using nsIHttpProtocolHandler::misc.
Attached patch patch — — Splinter Review 
Note that misc contains "rv:", platformVersion doesn't. This isn't a problem since when this hits a new channel, the version would change anyway.
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #599014 - Flags: review?(dolske)
Comment on attachment 599014 [details] [diff] [review]
patch

You can also get rid of the nsIXULAppInfo/nsIHttpProtocolHandler consts (the latter is used to initialize URI_INHERITS_SECURITY_CONTEXT, which also could be declared nearer to its one use!).
Attachment #599014 - Flags: review?(dolske) → review+
http://hg.mozilla.org/mozilla-central/rev/57c613f56cf9
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
You need to log in before you can comment on or make changes to this bug.