Closed Bug 728936 Opened 8 years ago Closed 8 years ago

Drop jquery*.min.js from test pilot

Categories

(Thunderbird :: General, defect)

defect
Not set

Tracking

(thunderbird12 fixed)

RESOLVED FIXED
Thunderbird 13.0
Tracking Status
thunderbird12 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

Attached patch The fixSplinter Review
Doing a few searches on the code for Test Pilot shows that we don't actually need the *.min.js files. These actually come from the shipped version of the "flot" extension to jquery which includes both the min and non-min files, so we should really just package the ones we need.
Attachment #598937 - Flags: review?(jdicarlo)
Blocks: 729127
Attachment #598937 - Flags: review?(jdicarlo) → review?(squibblyflabbetydoo)
Attachment #598937 - Flags: review?(irving)
Comment on attachment 598937 [details] [diff] [review]
The fix

Review of attachment 598937 [details] [diff] [review]:
-----------------------------------------------------------------

Can't see any reason why we need these files.
Attachment #598937 - Flags: review?(irving) → review+
Checked in: http://hg.mozilla.org/comm-central/rev/c04a8a9ed0f3
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 13.0
Comment on attachment 598937 [details] [diff] [review]
The fix

Clearing out my review, since this is already checked in. Sorry about dropping the ball on this...
Attachment #598937 - Flags: review?(squibblyflabbetydoo)
Comment on attachment 598937 [details] [diff] [review]
The fix

[Triage Comment]
Taking to beta as I want to get the version of test pilot we're distributing, synced up with the version on AMO.
Attachment #598937 - Flags: approval-comm-aurora+
Attachment #598937 - Flags: approval-comm-aurora+ → approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.