Closed Bug 728968 Opened 8 years ago Closed 8 years ago

clock_gettime() not detected on android

Categories

(Firefox Build System :: General, defect)

ARM
Android
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla13

People

(Reporter: jrmuizel, Assigned: glandium)

Details

Attachments

(1 file)

Android has clock_gettime() so we should be using it for TimeStamp::Now instead of using the slow PRInterval version.
This happens because we don't have -lrt on Android.
The configure message ends up awkward on android, but it works.
Attachment #599689 - Flags: review?(ted.mielczarek)
Comment on attachment 599689 [details] [diff] [review]
Detect clock_gettime when it's not in -lrt

I'm not going to have time to review this, shifting the review request.
Attachment #599689 - Flags: review?(ted.mielczarek) → review?(khuey)
Comment on attachment 599689 [details] [diff] [review]
Detect clock_gettime when it's not in -lrt

Review of attachment 599689 [details] [diff] [review]:
-----------------------------------------------------------------

You want to make the same change to js/src/configure.in, I believe.
Attachment #599689 - Flags: review?(khuey) → review+
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #4)
> Comment on attachment 599689 [details] [diff] [review]
> Detect clock_gettime when it's not in -lrt
> 
> Review of attachment 599689 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> You want to make the same change to js/src/configure.in, I believe.

I believe I want to remove the check in js/src/configure.in, as it's not used.
Assignee: nobody → mh+mozilla
https://hg.mozilla.org/mozilla-central/rev/7493a740efce
Status: NEW → RESOLVED
Closed: 8 years ago
OS: Mac OS X → Android
Hardware: x86 → ARM
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.