728977 - Maple: Use integer viewport coordinate

Status: RESOLVED WONTFIX

(Core :: Graphics, defect, P2)

Description

[Benoit Girard (:BenWa)]

Attachment: patch

Having float viewport coordinates is causing us a lot of problem with subpixel positionning that is leading us to invalidate our whole layer when doing a small pan. We really want to always use integers.

Comment 1

[JP Rosevear [:jpr]]

Any reason not to get review on this patch now Benoit?

Comment 2

[Benoit Girard (:BenWa)]

The patch is largely untested. I need to make sure that integer rounding doesn't introduce new bugs and that this patch is sufficient to prevent layout from invalidating the page on fractional coordinate. We currently have a work around for this issue so it's not affecting us.

I wouldn't block beta/release on this issue but I'd really like to fix up the code and remove the work around.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Sounds like we can fix this in bug 724786

Comment 4

[Benoit Girard (:BenWa)]

We shouldn't be using float to store the viewport in java, the patch in bug 724786 don't address that.

Comment 5

[Benoit Girard (:BenWa)]

This is no longer valid with changes we've made to the pan/zoom code.