Closed Bug 728977 Opened 14 years ago Closed 14 years ago

Maple: Use integer viewport coordinate

Categories

(Core :: Graphics, defect, P2)

Product:
Core
Component:
Graphics
Platform:
x86
macOS
Type:
defect

Tracking

()

Status:
RESOLVED WONTFIX
Tracking Flags:
Tracking Status
blocking-fennec1.0 --- -

People

(Reporter: BenWa, Assigned: BenWa)

References

Details

(Whiteboard: [gfx])

Attachments

(1 file)

patch
9.54 KB, patch
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review
Having float viewport coordinates is causing us a lot of problem with subpixel positionning that is leading us to invalidate our whole layer when doing a small pan. We really want to always use integers.
Assignee: nobody → bgirard
Priority: -- → P2
blocking-fennec1.0: --- → beta+
Status: NEW → ASSIGNED
Whiteboard: [gfx]
Any reason not to get review on this patch now Benoit?
The patch is largely untested. I need to make sure that integer rounding doesn't introduce new bugs and that this patch is sufficient to prevent layout from invalidating the page on fractional coordinate. We currently have a work around for this issue so it's not affecting us. I wouldn't block beta/release on this issue but I'd really like to fix up the code and remove the work around.
Sounds like we can fix this in bug 724786
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → DUPLICATE
We shouldn't be using float to store the viewport in java, the patch in bug 724786 don't address that.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
blocking-fennec1.0: beta+ → -
This is no longer valid with changes we've made to the pan/zoom code.
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: