Closed
Bug 729000
Opened 13 years ago
Closed 13 years ago
Remove 'about:robots' references in SeaMonkey
Categories
(SeaMonkey :: Session Restore, defect, P3)
SeaMonkey
Session Restore
Tracking
(Not tracked)
VERIFIED
FIXED
seamonkey2.10
People
(Reporter: sgautherie, Assigned: sgautherie)
References
()
Details
Attachments
(2 files, 1 obsolete file)
2.73 KB,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
770 bytes,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•13 years ago
|
||
Ports bug 728999
'os' was a leftover from bug 669077.
Attachment #599323 -
Flags: review?(neil)
Updated•13 years ago
|
Attachment #599323 -
Flags: review?(neil) → review+
Assignee | ||
Comment 2•13 years ago
|
||
Comment on attachment 599323 [details] [diff] [review]
(Av1) browser_526613.js: Use "about:mozilla" instead of "about:robots", Fix nits
[Checked in: Comment 2]
http://hg.mozilla.org/comm-central/rev/bf9a92cf0453
Attachment #599323 -
Attachment description: (Av1) browser_526613.js: Use "about:mozilla" instead of "about:robots", Fix nits → (Av1) browser_526613.js: Use "about:mozilla" instead of "about:robots", Fix nits
[Checked in: Comment 2]
Assignee | ||
Comment 3•13 years ago
|
||
Attachment #599830 -
Flags: review?(neil)
Assignee | ||
Comment 4•13 years ago
|
||
(In reply to Serge Gautherie (:sgautherie) from comment #2)
> http://hg.mozilla.org/comm-central/rev/bf9a92cf0453
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1329945228.1329949751.24673.gz&fulltext=1
WINNT 5.2 comm-central-trunk debug test mochitest-other on 2012/02/22 13:13:48
browser_526613.js passes (and does not report the 4 exceptions noticed in bug 728999 comment 0 anymore).
V.Fixed wrt this test.
Updated•13 years ago
|
Attachment #599830 -
Flags: review?(neil) → review+
Assignee | ||
Comment 5•13 years ago
|
||
Comment on attachment 599830 [details] [diff] [review]
(Bv1) browser_694378.js: Don't use "about:robots"
[Checked in: Comment 5]
http://hg.mozilla.org/comm-central/rev/bc9d250eb77e
Attachment #599830 -
Attachment description: (Bv1) browser_694378.js: Don't use "about:robots" → (Bv1) browser_694378.js: Don't use "about:robots"
[Checked in: Comment 5]
Assignee | ||
Updated•13 years ago
|
Assignee | ||
Comment 6•13 years ago
|
||
Nits from bug 463504 and bug 508039.
Attachment #600330 -
Flags: review?(neil)
Comment 7•13 years ago
|
||
Comment on attachment 600330 [details] [diff] [review]
(Cv1) Fix license references to "about:robots" in SeaMonkey
[superseded by bug 728478]
- * The Original Code is about:robots.
+ * The Original Code is about:rights.
- * The Original Code is about:robots
+ * The Original Code is about:certerror
Hmm, if the original code in these files comes from the about:rights file, I wonder if this is correct.
Assignee | ||
Comment 8•13 years ago
|
||
(In reply to Stefan [:stefanh] from comment #7)
> Hmm, if the original code in these files comes from the about:rights file, I
> wonder if this is correct.
I'm not sure: I thought "Original Code" just describes what the current file is. (Even if its code was copied/adapted from some other file.)
Related suggestion could be whether we would want to apply MPL 2.0:
http://www.mozilla.org/MPL/headers/
Comment 9•13 years ago
|
||
Comment on attachment 600330 [details] [diff] [review]
(Cv1) Fix license references to "about:robots" in SeaMonkey
[superseded by bug 728478]
Actually I want to remove these in bug 728478...
Attachment #600330 -
Flags: review?(neil)
Assignee | ||
Updated•13 years ago
|
Attachment #600330 -
Attachment description: (Cv1) Fix license references to "about:robots" in SeaMonkey → (Cv1) Fix license references to "about:robots" in SeaMonkey
[superseded by bug 728478]
Attachment #600330 -
Attachment is obsolete: true
Assignee | ||
Comment 10•13 years ago
|
||
V.Fixed
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Assignee | ||
Updated•13 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•