Add memory reporter for FramePropertyTable

RESOLVED FIXED in mozilla13

Status

()

Core
Layout
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

(Blocks: 1 bug)

unspecified
mozilla13
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 599048 [details] [diff] [review]
patch

DMD pointed me at FramePropertyTable.  On a workload of 14 wikipedia tabs, the this patch improves coverage of layout memory by about 1.3MB of additional layout memory.

Other minor changes:
- Renamed "layout/styledata" reports as "layout/style-sets".
- |const|-ifies nsTHashTable::SizeOfIncludingThis
Attachment #599048 - Flags: review?(bzbarsky)
Comment on attachment 599048 [details] [diff] [review]
patch

r=me

It's interesting that we're getting 1.3MB of proptable storage but not that much for the values... Might be worth seeing whether we should do some reporting for the values too at some point.
Attachment #599048 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 2

5 years ago
> It's interesting that we're getting 1.3MB of proptable storage but not that
> much for the values... Might be worth seeing whether we should do some
> reporting for the values too at some point.

That's what this comment is about:

+      // We don't need to measure mProperty because it always points to static
+      // memory.  As for mValue:  if it's a single value we can't measure it,
+      // because the type is opaque;  if it's an array, we measure the array
+      // storage, but we can't measure the individual values, again because
+      // their types are opaque.

However, we have mProperty->mDestructor and mProperty->mDestructorWithFrame;  I could add mProperty->mSizeOfIncludingthis...
Yeah, perhaps as a followup if we see those allocations.
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/878c5c8b8b21
https://hg.mozilla.org/mozilla-central/rev/878c5c8b8b21
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.