729008 - Add memory reporter for FramePropertyTable

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Nicholas Nethercote [inactive]]

Attachment: patch

DMD pointed me at FramePropertyTable.  On a workload of 14 wikipedia tabs, the this patch improves coverage of layout memory by about 1.3MB of additional layout memory.

Other minor changes:
- Renamed "layout/styledata" reports as "layout/style-sets".
- |const|-ifies nsTHashTable::SizeOfIncludingThis

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 599048 [details] [diff] [review]
patch

r=me

It's interesting that we're getting 1.3MB of proptable storage but not that much for the values... Might be worth seeing whether we should do some reporting for the values too at some point.

Comment 2

[Nicholas Nethercote [inactive]]

> It's interesting that we're getting 1.3MB of proptable storage but not that
> much for the values... Might be worth seeing whether we should do some
> reporting for the values too at some point.

That's what this comment is about:

+      // We don't need to measure mProperty because it always points to static
+      // memory.  As for mValue:  if it's a single value we can't measure it,
+      // because the type is opaque;  if it's an array, we measure the array
+      // storage, but we can't measure the individual values, again because
+      // their types are opaque.

However, we have mProperty->mDestructor and mProperty->mDestructorWithFrame;  I could add mProperty->mSizeOfIncludingthis...

Comment 3

[Boris Zbarsky [:bzbarsky]]

Yeah, perhaps as a followup if we see those allocations.

Comment 4

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/878c5c8b8b21

Comment 5

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/878c5c8b8b21