729027 - Identity Settings dialog is too large (high) for netbook

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

The Identity Settings dialog (Click [Manage Identities...], select an item on the opened dialog and click [Edit...] button, then, you can see it) is too large (high) for netbooks.

Maybe, it's better to shrink the dialog if we can change the design.

However, if it's nice to change the dialog resizeable and scrollable in the tabs' contents for temporarily (The Account Settings is so).

For the latter, I set [good first bug].

Comment 1

[:aceman]

Yes, the main Account manager window is resizable but the Manage identities isn't. I wonder how hard it is to allow resizability.

Comment 2

[:aceman]

The indetities dialog is so tall because of the Copies & folders pane. The other ones have plenty of space.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Sure, if somebody has idea separating the contents in the tab, it may be better fix.

Comment 4

[Magnus Melin [:mkmelin]]

You'd just add "resizable" to the dialog opening arguments. And then make sure it scrolls, maybe something like bug 567280.

Comment 5

[:aceman]

Thanks, will check it out.

Comment 6

[Magnus Melin [:mkmelin]]

Opening the dialog is http://hg.mozilla.org/comm-central/annotate/6c605636afe1/mailnews/base/prefs/content/am-identities-list.js#l82

Then go through am-identity-edit.xul and add boxes with style="overflow: auto" like in https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=567280&attachment=561799

Comment 7

[Kapil Singh [:kapy]]

Hi, is this bug still applicable ? If it is, I would like to work on it.

Thanks,
Kapil

Comment 8

[Mike Hoye [:mhoye]]

Hi, Kapil - thanks for your interest; I'm going to check the "needinfo" box here to bring this to the attention of Magnus, this bug's mentor, so we can answer your question.

Comment 9

[Magnus Melin [:mkmelin]]

Ki Kapil, yes it's still applicable. (Just try setting your resolution to 800x600 or something like it to reproduce.)
Let me know if you have any questions.

Comment 10

[Kapil Singh [:kapy]]

Attachment: Fix for large dialog display

I have added resizability and scrollability to the edit manage identities dialog box.

Thanks,
Kapil

Comment 11

[Magnus Melin [:mkmelin]]

Comment on attachment 8599366 [details] [diff] [review]
Fix for large dialog display

Review of attachment 8599366 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay.
Seems to work, but I do get a scrollbar (always) on opening.

::: mailnews/base/prefs/content/am-identity-edit.xul
@@ +37,5 @@
>  
>    <description flex="1">&identityListDesc.label;</description>
>    <separator class="thin"/>
>  
> +  <vbox flex="1" style="overflow: auto">

I think you can just put this on the tabbox

Comment 12

[Magnus Melin [:mkmelin]]

Comment on attachment 8599366 [details] [diff] [review]
Fix for large dialog display

Review of attachment 8599366 [details] [diff] [review]:
-----------------------------------------------------------------

Can you increase the default height a small amount so that there aren't scrollbars by default?

Comment 13

[Aadithya B K]

can somebody tell me where I can find Manage identity options ?

I tried to google it and I do not have it in Tools > Options > Account settings in spite of creating an account.

Comment 14

[Aadithya B K]

(In reply to Aadithya B K from comment #13)
> can somebody tell me where I can find Manage identity options ?
> 
> I tried to google it and I do not have it in Tools > Options > Account
> settings in spite of creating an account.

My bad. I found it.

Comment 15

[Shaif]

Attachment: patch729027.diff Fix for large dialog display

Is this all right?

Comment 16

[Magnus Melin [:mkmelin]]

Comment on attachment 8722882 [details] [diff] [review]
patch729027.diff  Fix for large dialog display

Review of attachment 8722882 [details] [diff] [review]:
-----------------------------------------------------------------

You might want to do this to set creds to yourself:

hg qrefresh -U

::: mailnews/base/prefs/content/am-identities-list.js
@@ +79,5 @@
>    let indexToSelect = identity ? gIdentityListBox.selectedIndex :
>                                   gIdentityListBox.itemCount;
>  
>    window.openDialog("am-identity-edit.xul", "",
> +                    "chrome,modal,resizable=yes,centerscreen", args);

nit: the "=yes" is not needed

Comment 17

[Magnus Melin [:mkmelin]]

Never mind regarding the creds... got confused about the obsolete patch.

Comment 18

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/comm-central/rev/7b5667355f55 -> FIXED

Comment 19

[Magnus Melin [:mkmelin]]

Comment on attachment 8722882 [details] [diff] [review]
patch729027.diff  Fix for large dialog display

Review of attachment 8722882 [details] [diff] [review]:
-----------------------------------------------------------------

Safe change that makes the identity dialog work on small screens

Comment 20

[Jorg K (CEST = GMT+2)]

Aurora (TB 46):
https://hg.mozilla.org/releases/comm-aurora/rev/a95ca02243e2

Comment 21

[Kent James (:rkent)]

Comment on attachment 8722882 [details] [diff] [review]
patch729027.diff  Fix for large dialog display

http://hg.mozilla.org/releases/comm-esr45/rev/1921fba9d7b1