The default bug view has changed. See this FAQ.

Mozmill test failure //testAwesomeBar/testGoButton.js | controller.assertJS: Failed for 'subject.visible == subject.expectedVisibility'

RESOLVED WORKSFORME

Status

Mozilla QA
Mozmill Tests
RESOLVED WORKSFORME
5 years ago
5 years ago

People

(Reporter: vladmaniac, Assigned: AlexLakatos)

Tracking

unspecified
x86
Linux
Bug Flags:
in-litmus +

Firefox Tracking Flags

(firefox13 fixed, firefox14 fixed, firefox15 fixed, firefox16 fixed, firefox-esr10 unaffected)

Details

(Whiteboard: [mozmill-test-failure])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
Firefox version: Firefox 13.0a1 (13.0a1, en-US, 20120218031156)
-----------------------------------------------------------------------------
Platform: All 
-----------------------------------------------------------------------------
Mozmill version: 1.5.7 
-----------------------------------------------------------------------------
First started failling: 2012/02/18
-----------------------------------------------------------------------------
Currently failling on Nightly/default branch 
-----------------------------------------------------------------------------
Report: http://mozmill-release.blargon7.com/#/functional/report/55d601cc2aabfac28f59060a84a11ad4
-----------------------------------------------------------------------------
Error: assert((function () {return eval(expression);}),"controller.assertJS: Failed for 'subject.visible == subject.expectedVisibility'")@resource://mozmill/modules/utils.js:395 ("subject.visible == subject.expectedVisibility",[object Proxy])@resource://mozmill/modules/controller.js:931
(Reporter)

Comment 1

5 years ago
The fix for this test would definitely depend on Alex's assertJS refactoring patch. 

I'll investigate bug 729037 see if the patch for that helps or fixes this one too. 
If not assigning to Alex later today for investigation/fix/skip the test
Depends on: 724713
(Reporter)

Updated

5 years ago
Whiteboard: [mozmill-test-failure][mozmill-functional]
(Assignee)

Comment 2

5 years ago
Created attachment 599137 [details] [diff] [review]
skipPatch v1.0 [landed:default,aurora,beta]

Skipping the test until I resolve the dependency.
Assignee: nobody → alex.lakatos
Status: NEW → ASSIGNED
Attachment #599137 - Flags: review?(anthony.s.hughes)
Comment on attachment 599137 [details] [diff] [review]
skipPatch v1.0 [landed:default,aurora,beta]

Landed:
http://hg.mozilla.org/qa/mozmill-tests/rev/7022a1b9997e (default)
Attachment #599137 - Attachment description: skipPatch v1.0 → skipPatch v1.0 [landed]
Attachment #599137 - Flags: review?(anthony.s.hughes) → review+
Whiteboard: [mozmill-test-failure][mozmill-functional] → [mozmill-test-failure][mozmill-test-skipped]
Comment on attachment 599137 [details] [diff] [review]
skipPatch v1.0 [landed:default,aurora,beta]

Note, as per recent merges, this test is now disabled on Nightly, Aurora, and Beta.
Attachment #599137 - Attachment description: skipPatch v1.0 [landed] → skipPatch v1.0 [landed:default,aurora,beta]
Alex, any update on this bug?
It's been almost two weeks since Henrik's reminder. Any updates?
(Assignee)

Comment 7

5 years ago
Created attachment 633992 [details] [diff] [review]
patch v1.0

(In reply to Dave Hunt (:davehunt) [away until 14th June] from comment #6)
> It's been almost two weeks since Henrik's reminder. Any updates?
The comment seems to have fallen through my mail filters.

This does not fail anymore, so here is the patch that enables it and cleans the litmus reference.
Attachment #633992 - Flags: review?
(Assignee)

Updated

5 years ago
Attachment #633992 - Flags: review? → review?(dave.hunt)
Comment on attachment 633992 [details] [diff] [review]
patch v1.0

We do not need a separate patch. We will backout the original patch instead. Do you have any reports which show that this test is no longer failing?
Attachment #633992 - Attachment is obsolete: true
Attachment #633992 - Flags: review?(dave.hunt)
(Assignee)

Comment 9

5 years ago
(In reply to Henrik Skupin (:whimboo) from comment #8)
> Comment on attachment 633992 [details] [diff] [review]
> patch v1.0
> 
> We do not need a separate patch. We will backout the original patch instead.
> Do you have any reports which show that this test is no longer failing?
Yes, here is one.
http://mozmill-crowd.blargon7.com/#/functional/report/8bf3fa70d3d9a46d3e7617383b1161c6
This has to be tested across all platforms. Otherwise it's too risky to re-enable the test.
(Assignee)

Comment 11

5 years ago
Tested across MacOSX, Win 7 and Windows XP. They all passed. But seeing as how http://mozmill-crowd.blargon7.com/ is still down, I can't attach links.
I will re-run them once the dashboard is up, so we can have reports.
The IrisCouch outage has been fixed. So please re-run as soon as possible so we could have this test enabled for the tests today.
(Assignee)

Comment 13

5 years ago
Here are the reports:
http://mozmill-crowd.blargon7.com/#/functional/report/c67fb1fc2ea8384105b843e32c008028
http://mozmill-crowd.blargon7.com/#/functional/report/c67fb1fc2ea8384105b843e32c00cbe5
http://mozmill-crowd.blargon7.com/#/functional/report/c67fb1fc2ea8384105b843e32c00e84b

The test passes in all of them.
Sounds good. But next time please make sure to update the local repository before running the tests. At least the last one is really outdated.

Pushed:
http://hg.mozilla.org/qa/mozmill-tests/rev/fdb54e829795 (default)

Alex please check which branches are affected and would need this to be backed-out. Also please reference the changesets because I only see one for default.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
status-firefox16: --- → fixed
Resolution: --- → FIXED
Resolution: FIXED → WORKSFORME
(Assignee)

Updated

5 years ago
status-firefox-esr10: --- → unaffected
status-firefox13: --- → affected
status-firefox14: --- → affected
status-firefox15: --- → affected
(Assignee)

Comment 15

5 years ago
Dave, can you please transplant the patch to the affected branches?
Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/c08d3833d1c0 (mozilla-aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/d8c2c817d455 (mozilla-beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/6225fdae24f2 (mozilla-release)

Updated

5 years ago
status-firefox13: affected → fixed
status-firefox14: affected → fixed
status-firefox15: affected → fixed
Alex, please re-enable all the litmus tests.
Flags: in-litmus?(alex.lakatos)
Whiteboard: [mozmill-test-failure][mozmill-test-skipped] → [mozmill-test-failure]
(Assignee)

Comment 18

5 years ago
https://litmus.mozilla.org/show_test.cgi?id=63770
https://litmus.mozilla.org/show_test.cgi?id=15423
Flags: in-litmus?(alex.lakatos) → in-litmus+
Alex, please check the flags when updating the litmus tests. It's missing an update for Firefox 13.
Flags: in-litmus+ → in-litmus?(alex.lakatos)
(Assignee)

Comment 20

5 years ago
The test for the Firefox 13 Branch did not need updating, I checked. That's why I only pasted the two links.
https://litmus.mozilla.org/show_test.cgi?id=55416
Flags: in-litmus?(alex.lakatos) → in-litmus+
Always paste all the litmus test URLs of the affected branches. Only that way we can verify it correctly. Thanks.
You need to log in before you can comment on or make changes to this bug.