Closed Bug 729042 Opened 10 years ago Closed 10 years ago

SMS: Add nsISmsDatabaseService::saveIncomingMessage()

Categories

(Core :: DOM: Device Interfaces, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: philikon, Assigned: philikon)

References

Details

Attachments

(1 file)

Android may automatically save incoming messages to the database, but in the RIL/Gonk backend, we need to do so explicitly, so the database service will need a method for that.
Attached patch v1Splinter Review
Assignee: nobody → philipp
Attachment #599225 - Flags: review?(mounir)
Comment on attachment 599225 [details] [diff] [review]
v1

Review of attachment 599225 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/sms/src/android/SmsDatabaseService.cpp
@@ +49,5 @@
> +SmsDatabaseService::SaveReceivedMessage(const nsAString& aSender,
> +                                        const nsAString& aBody,
> +                                        PRUint64 aDate, PRInt32* aId)
> +{
> +  // Android does this already.

nit:
// Android stock SMS app does this already.
Attachment #599225 - Flags: review?(mounir) → review+
Try run for 535ac18bc6f5 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=535ac18bc6f5
Results (out of 3 total builds):
    success: 3
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/pweitershausen@mozilla.com-535ac18bc6f5
https://hg.mozilla.org/mozilla-central/rev/3ef541a42d12
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.