729042 - SMS: Add nsISmsDatabaseService::saveIncomingMessage()

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Philipp von Weitershausen [:philikon]]

Android may automatically save incoming messages to the database, but in the RIL/Gonk backend, we need to do so explicitly, so the database service will need a method for that.

Comment 1

[Philipp von Weitershausen [:philikon]]

Attachment: v1

Comment 2

[Mounir Lamouri (:mounir)]

Comment on attachment 599225 [details] [diff] [review]
v1

Review of attachment 599225 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/sms/src/android/SmsDatabaseService.cpp
@@ +49,5 @@
> +SmsDatabaseService::SaveReceivedMessage(const nsAString& aSender,
> +                                        const nsAString& aBody,
> +                                        PRUint64 aDate, PRInt32* aId)
> +{
> +  // Android does this already.

nit:
// Android stock SMS app does this already.

Comment 3

[Mozilla RelEng Bot]

Try run for 535ac18bc6f5 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=535ac18bc6f5
Results (out of 3 total builds):
    success: 3
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-535ac18bc6f5

Comment 4

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3ef541a42d12

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3ef541a42d12