java.lang.NullPointerException @ org.mozilla.gecko.GeckoApp.processThumbnail(GeckoApp.java:642)

RESOLVED FIXED in Firefox 13

Status

()

defect
--
critical
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: aaronmt, Assigned: mfinkle)

Tracking

({crash})

Trunk
Firefox 13
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [native-crash])

Attachments

(1 attachment)

Reporter

Description

7 years ago
I/ActivityManager(  196): Displayed org.mozilla.fennec/org.mozilla.gecko.TabsTray: +480ms
I/GeckoTabs( 5816): Removed a tab with id: 30
I/GeckoToolbar( 5816): zerdatime 6306386 - Throbber stop
I/GeckoDoorHangerPopup( 5816): Showing all doorhangers for tab: 29
I/GeckoDoorHangerPopup( 5816): Showing all doorhangers for tab: 29
D/GeckoLayerController( 5816): setViewportMetrics: v=RectF(0.0, 0.0, 720.0, 1038.0) p=(720.0,1323.1837) z=0.7346939 o=0.0,0.0
I/GeckoSoftwareLayerClient( 5816): zerdatime 6306594 - endDrawing
D/GeckoPanZoomController( 5816): generating valid viewport using v=RectF(0.0, 0.0, 720.0, 1038.0) p=(720.0,1323.1837) z=0.7346939 o=0.0,0.0
D/GeckoPanZoomController( 5816): generated valid viewport as v=RectF(0.0, 0.0, 720.0, 1038.0) p=(720.0,1323.1837) z=0.7346939 o=0.0,0.0
D/GeckoLayerController( 5816): setViewportMetrics: v=RectF(0.0, 0.0, 720.0, 1038.0) p=(720.0,1323.1837) z=0.7346939 o=0.0,0.0
I/GeckoSoftwareLayerClient( 5816): zerdatime 6306668 - endDrawing
E/AndroidRuntime( 5816): FATAL EXCEPTION: GeckoLooper Thread
E/AndroidRuntime( 5816): java.lang.NullPointerException
E/AndroidRuntime( 5816): 	at org.mozilla.gecko.GeckoApp.processThumbnail(GeckoApp.java:642)
E/AndroidRuntime( 5816): 	at org.mozilla.gecko.GeckoAppShell$3.run(GeckoAppShell.java:577)
E/AndroidRuntime( 5816): 	at android.os.Handler.handleCallback(Handler.java:605)
E/AndroidRuntime( 5816): 	at android.os.Handler.dispatchMessage(Handler.java:92)
E/AndroidRuntime( 5816): 	at android.os.Looper.loop(Looper.java:137)
E/AndroidRuntime( 5816): 	at org.mozilla.gecko.GeckoAppShell$LooperThread.run(GeckoAppShell.java:193)
W/ActivityManager(  196):   Force finishing activity org.mozilla.fennec/org.mozilla.gecko.TabsTray

--
Nightly (02/21)
Samsung Galaxy Nexus (Android 4.0.2)
Mozilla/5.0 (Android; Mobile; rv:13.0) Gecko/13.0 Firefox/13.0a1
Posted patch patchSplinter Review
Looks like thumbnailTab.getURL() is returning null. I don't know exactly why. This patch guards against that, but maybe we should have the getter return an empty string if Tab.mUrl is null.
Assignee: nobody → mark.finkle
Attachment #599179 - Flags: review?(blassey.bugs)
Comment on attachment 599179 [details] [diff] [review]
patch

Review of attachment 599179 [details] [diff] [review]:
-----------------------------------------------------------------

this is the "right" way to do a string comparison to a string literal in java.

I like returning null over returning an empty string. If null truly isn't expected, file a follow up to investigate.
Attachment #599179 - Flags: review?(blassey.bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/df37b05eaefb
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
You need to log in before you can comment on or make changes to this bug.