Closed
Bug 729135
Opened 14 years ago
Closed 14 years ago
fix virtual function warnings in core plugin code
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla13
People
(Reporter: jaas, Assigned: jaas)
Details
Attachments
(1 file, 1 obsolete file)
|
1.42 KB,
patch
|
Details | Diff | Splinter Review |
I'm getting some legit virtual function warnings from clang in core plugin code.
Attachment #599199 -
Flags: review?(benjamin)
|
||
Updated•14 years ago
|
Attachment #599199 -
Flags: review?(benjamin) → review+
try run including fix v1.0
https://tbpl.mozilla.org/?tree=Try&rev=bb42859762a6
test_pluginstream_newstream.html | Exited with code 1 during test run
This causes a test failure because we try to QI an nsNPAPIStreamWrapper object in _destroystream.
a less invasive fix, leave the xpcom object alone
try server run:
https://tbpl.mozilla.org/?tree=Try&rev=dad590a3a819
Attachment #599199 -
Attachment is obsolete: true
pushed to mozilla-inbound
http://hg.mozilla.org/integration/mozilla-inbound/rev/615ee091ee66
|
||
Comment 5•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
|
||
Updated•4 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•