Closed Bug 729135 Opened 11 years ago Closed 11 years ago

fix virtual function warnings in core plugin code

Categories

(Core Graveyard :: Plug-ins, defect)

Product:
Core Graveyard
Component:
Plug-ins
Version:
12 Branch
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla13

People

(Reporter: jaas, Assigned: jaas)

Details

Attachments

(1 file, 1 obsolete file)

fix v1.1
1.42 KB, patch
Details | Diff | Splinter Review
Attached patch fix v1.0 (obsolete) — — Splinter Review 
I'm getting some legit virtual function warnings from clang in core plugin code.
Attachment #599199 - Flags: review?(benjamin)
Attachment #599199 - Flags: review?(benjamin) → review+
try run including fix v1.0

https://tbpl.mozilla.org/?tree=Try&rev=bb42859762a6
test_pluginstream_newstream.html | Exited with code 1 during test run

This causes a test failure because we try to QI an nsNPAPIStreamWrapper object in _destroystream.
Attached patch fix v1.1 — — Splinter Review 
a less invasive fix, leave the xpcom object alone

try server run:

https://tbpl.mozilla.org/?tree=Try&rev=dad590a3a819
Attachment #599199 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/615ee091ee66
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.