729144 - post to a staging version of the new graphs.m.o

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Armen [:armenzg]]

In bug 727355 and bug 728271 we want to switch completely from graphs-old.mozilla.org.

Up until now, the staging host of graphs-old is graphs-stage.

I would like to know if graphs.allizom.org is the right thing and switch to it.

Comment 1

[Armen [:armenzg]]

Attachment: [being tested] switch to graphs.allizom.org

Comment 2

[Robert Helmer [:rhelmer]]

(In reply to Armen Zambrano G. [:armenzg] - Release Engineer from comment #0)
> In bug 727355 and bug 728271 we want to switch completely from
> graphs-old.mozilla.org.
> 
> Up until now, the staging host of graphs-old is graphs-stage.
> 
> I would like to know if graphs.allizom.org is the right thing and switch to
> it.

Just in case you still needed confirmation, yes graphs.allizom.org is stage and there are no plans to change (this matches what other mozilla web sites do, such as addons.allizom.org and crash-stats.allizom.org)

Comment 3

[Armen [:armenzg]]

I see a warning and the URLs don't load up "Error. Could not add node. Exception: TypeError"

[0]
http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTest/1330963410.1330965831.19401.gz&fulltext=1

[1]
WARNING: graph server Status 500 Internal Server Error : http://graphs.allizom.org/server/collect.cgi
WARNING: graph server link does not exist

[2]
RETURN:<a href='http://graphs.allizom.org/graph.html#tests=[{"test":74,"branch":106,"machine":2263}]'>dromaeo_jslib: 128.53</a><br>
RETURN:<a href='http://graphs.allizom.org/graph.html#tests=[{"test":73,"branch":106,"machine":2263}]'>dromaeo_dom: 179.96</a><br>
RETURN:<a href='http://graphs.allizom.org/graph.html#tests=[{"test":76,"branch":106,"machine":2263}]'>dromaeo_v8: 376.71</a><br>
RETURN:<a href='http://graphs.allizom.org/graph.html#tests=[{"test":77,"branch":106,"machine":2263}]'>dromaeo_basics: 712.36</a><br>
RETURN:<a href='http://graphs.allizom.org/graph.html#tests=[{"test":75,"branch":106,"machine":2263}]'>dromaeo_sunspider: 1187.67</a><br>
RETURN:<a href='http://graphs.allizom.org/graph.html#tests=[{"test":72,"branch":106,"machine":2263}]'>dromaeo_css: 2609.86</a><br>

Comment 4

[Robert Helmer [:rhelmer]]

(In reply to Armen Zambrano G. [:armenzg] - Release Engineer from comment #3)
> I see a warning and the URLs don't load up "Error. Could not add node.
> Exception: TypeError"

Can you give an example URL? Are you using the 

 
> [0]
> http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTest/1330963410.
> 1330965831.19401.gz&fulltext=1
> 
> [1]
> WARNING: graph server Status 500 Internal Server Error :
> http://graphs.allizom.org/server/collect.cgi

I am concerned about this - does this mean that you got an HTTP 500 back from the POST? 

> WARNING: graph server link does not exist

Do you know what this warning means?

Feel free to just link me to the proper source code and I can look too :)


> [2]
> RETURN:<a
> href='http://graphs.allizom.org/graph.html#tests=[{"test":74,"branch":106,
> "machine":2263}]'>dromaeo_jslib: 128.53</a><br>
> RETURN:<a
> href='http://graphs.allizom.org/graph.html#tests=[{"test":73,"branch":106,
> "machine":2263}]'>dromaeo_dom: 179.96</a><br>
> RETURN:<a
> href='http://graphs.allizom.org/graph.html#tests=[{"test":76,"branch":106,
> "machine":2263}]'>dromaeo_v8: 376.71</a><br>
> RETURN:<a
> href='http://graphs.allizom.org/graph.html#tests=[{"test":77,"branch":106,
> "machine":2263}]'>dromaeo_basics: 712.36</a><br>
> RETURN:<a
> href='http://graphs.allizom.org/graph.html#tests=[{"test":75,"branch":106,
> "machine":2263}]'>dromaeo_sunspider: 1187.67</a><br>
> RETURN:<a
> href='http://graphs.allizom.org/graph.html#tests=[{"test":72,"branch":106,
> "machine":2263}]'>dromaeo_css: 2609.86</a><br>

Oh, are these the URLs you're trying to load ^?

Yeah the new frontend doesn't support that URL scheme, although I get a more direct error message:

Error
Could not understand URL
Exception: SyntaxError

The main problem is that the new UI links to a platform instead of a specific machine, we could add support for it if it's useful though.

Here is an example of loading all valid platforms for the dramaeo_css test (note the test and branch ID are the same):

not supported: http://graphs.allizom.org/graph.html#tests=[{"test":72,"branch":106,"machine":2263}

supported: http://graphs.allizom.org/graph.html#tests=[[72,1,1],[72,1,14],[72,1,15],[72,1,12],[72,1,13],[72,1,17],[72,1,22],[72,1,21],[72,1,19]]

I could make /server/collect return the platform instead of the machine perhaps.

Comment 5

[Armen [:armenzg]]

(In reply to Robert Helmer [:rhelmer] from comment #4)
> > [0]
> > http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTest/1330963410.
> > 1330965831.19401.gz&fulltext=1
> > 
> > [1]
> > WARNING: graph server Status 500 Internal Server Error :
> > http://graphs.allizom.org/server/collect.cgi
> 
> I am concerned about this - does this mean that you got an HTTP 500 back
> from the POST? 
> 
> > WARNING: graph server link does not exist
> 
> Do you know what this warning means?
> 
> Feel free to just link me to the proper source code and I can look too :)

I don't know what the warning means.
I found the code in here:
http://mxr.mozilla.org/build/source/talos/talos/run_tests.py#471

> 
> 
> > [2]
> > RETURN:<a
> > href='http://graphs.allizom.org/graph.html#tests=[{"test":74,"branch":106,
> > "machine":2263}]'>dromaeo_jslib: 128.53</a><br>
> > RETURN:<a
> > href='http://graphs.allizom.org/graph.html#tests=[{"test":73,"branch":106,
> > "machine":2263}]'>dromaeo_dom: 179.96</a><br>
> > RETURN:<a
> > href='http://graphs.allizom.org/graph.html#tests=[{"test":76,"branch":106,
> > "machine":2263}]'>dromaeo_v8: 376.71</a><br>
> > RETURN:<a
> > href='http://graphs.allizom.org/graph.html#tests=[{"test":77,"branch":106,
> > "machine":2263}]'>dromaeo_basics: 712.36</a><br>
> > RETURN:<a
> > href='http://graphs.allizom.org/graph.html#tests=[{"test":75,"branch":106,
> > "machine":2263}]'>dromaeo_sunspider: 1187.67</a><br>
> > RETURN:<a
> > href='http://graphs.allizom.org/graph.html#tests=[{"test":72,"branch":106,
> > "machine":2263}]'>dromaeo_css: 2609.86</a><br>
> 
> Oh, are these the URLs you're trying to load ^?
> 
> Yeah the new frontend doesn't support that URL scheme, although I get a more
> direct error message:
> 
> Error
> Could not understand URL
> Exception: SyntaxError
> 
> The main problem is that the new UI links to a platform instead of a
> specific machine, we could add support for it if it's useful though.
> 
> Here is an example of loading all valid platforms for the dramaeo_css test
> (note the test and branch ID are the same):
> 
> not supported:
> http://graphs.allizom.org/graph.html#tests=[{"test":72,"branch":106,
> "machine":2263}
> 
> supported:
> http://graphs.allizom.org/graph.html#tests=[[72,1,1],[72,1,14],[72,1,15],[72,
> 1,12],[72,1,13],[72,1,17],[72,1,22],[72,1,21],[72,1,19]]
> 
> I could make /server/collect return the platform instead of the machine
> perhaps.

I think platform is fine.

We probably would have to ask the a-team to fix this. Otherwise, tbpl would be giving developers unusable URLs.

Comment 6

[Armen [:armenzg]]

rhelmer asked me to trigger it once more.

I still see the WARNING (which we don't know yet if it is important):
WARNING: graph server Status 500 Internal Server Error : http://graphs.allizom.org/server/collect.cgi
WARNING: graph server link does not exist

but this time I can load up the link:
RETURN:<a href='http://graphs.allizom.org/graph.html#tests=[[158,106,12]]'>tp5r_responsiveness_paint: 386.0</a><br>

another "but", I can't load these urls:
RETURN:<p style="font-size:smaller;">Details:<br>|
<a href='http://graphs.allizom.org/graph.html#type=series&tests=[{"test":139,"branch":106,"machine":885,"testrun":10557382}]'>tp5r_paint</a> |
<a href='http://graphs.allizom.org/graph.html#type=series&tests=[{"test":154,"branch":106,"machine":885,"testrun":10557383}]'>tp5r_modlistbytes_paint</a> |
<a href='http://graphs.allizom.org/graph.html#type=series&tests=[{"test":150,"branch":106,"machine":885,"testrun":10557384}]'>tp5r_%cpu_paint</a> |
<a href='http://graphs.allizom.org/graph.html#type=series&tests=[{"test":144,"branch":106,"machine":885,"testrun":10557385}]'>tp5r_main_rss_paint</a> |
<a href='http://graphs.allizom.org/graph.html#type=series&tests=[{"test":140,"branch":106,"machine":885,"testrun":10557386}]'>tp5r_pbytes_paint</a> |
<a href='http://graphs.allizom.org/graph.html#type=series&tests=[{"test":156,"branch":106,"machine":885,"testrun":10557387}]'>tp5r_shutdown_paint</a> |</p>

There are more logs in here if needed:
http://tinderbox.mozilla.org/showbuilds.cgi?tree=MozillaTest

Comment 7

[Robert Helmer [:rhelmer]]

(In reply to Armen Zambrano G. [:armenzg] - Release Engineer from comment #6)
> rhelmer asked me to trigger it once more.
> 
> I still see the WARNING (which we don't know yet if it is important):
> WARNING: graph server Status 500 Internal Server Error :
> http://graphs.allizom.org/server/collect.cgi

This is really odd, I only see HTTP 200 in the server logs (and I don't see where in the code you linked before this could be coming from).

> WARNING: graph server link does not exist

I assume these don't happen on normal talos runs? I don't see any difference in the results when I do a test post to the old graphs-stage versus graphs.allizom.org


> but this time I can load up the link:
> RETURN:<a
> href='http://graphs.allizom.org/graph.html#tests=[[158,106,
> 12]]'>tp5r_responsiveness_paint: 386.0</a><br>
> 
> another "but", I can't load these urls:
> RETURN:<p style="font-size:smaller;">Details:<br>|
> <a
> href='http://graphs.allizom.org/graph.html#type=series&tests=[{"test":139,
> "branch":106,"machine":885,"testrun":10557382}]'>tp5r_paint</a> |

Hmm where did these URLs come from, are they from the previous run or this run?

Comment 8

[Armen [:armenzg]]

(In reply to Robert Helmer [:rhelmer] from comment #7)
> (In reply to Armen Zambrano G. [:armenzg] - Release Engineer from comment #6)
> > rhelmer asked me to trigger it once more.
> > 
> > I still see the WARNING (which we don't know yet if it is important):
> > WARNING: graph server Status 500 Internal Server Error :
> > http://graphs.allizom.org/server/collect.cgi
> 
> This is really odd, I only see HTTP 200 in the server logs (and I don't see
> where in the code you linked before this could be coming from).
> 
> > WARNING: graph server link does not exist
> 
> I assume these don't happen on normal talos runs? I don't see any difference
> in the results when I do a test post to the old graphs-stage versus
> graphs.allizom.org
> 
No difference with production AFAIK.

> 
> > but this time I can load up the link:
> > RETURN:<a
> > href='http://graphs.allizom.org/graph.html#tests=[[158,106,
> > 12]]'>tp5r_responsiveness_paint: 386.0</a><br>
> > 
> > another "but", I can't load these urls:
> > RETURN:<p style="font-size:smaller;">Details:<br>|
> > <a
> > href='http://graphs.allizom.org/graph.html#type=series&tests=[{"test":139,
> > "branch":106,"machine":885,"testrun":10557382}]'>tp5r_paint</a> |
> 
> Hmm where did these URLs come from, are they from the previous run or this
> run?

From the latest runs.
Here is one of them if you want to look at the log:
Here is one of the URLs:
http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTest/1331142552.1331143406.16812.gz&fulltext=1

Comment 9

[Armen [:armenzg]]

(In reply to Robert Helmer [:rhelmer] from comment #7)
> (In reply to Armen Zambrano G. [:armenzg] - Release Engineer from comment #6)
> > rhelmer asked me to trigger it once more.
> > 
> > I still see the WARNING (which we don't know yet if it is important):
> > WARNING: graph server Status 500 Internal Server Error :
> > http://graphs.allizom.org/server/collect.cgi
> 
> This is really odd, I only see HTTP 200 in the server logs (and I don't see
> where in the code you linked before this could be coming from).
> 
It most likely comes from here:
http://mxr.mozilla.org/build/source/talos/talos/post_file.py

Comment 10

[Armen [:armenzg]]

rhelmer I believe this is fixed now:
http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTest/1331153692.1331153944.5590.gz&fulltext=1

* No warning
* All URLs work

Anything else we should be checking? I think after you land your changes we're ready to go, no?

On another note, can you point us to the fix for the record?

RETURN:<a href='http://graphs.allizom.org/graph.html#tests=[[163,106,12]]'>tsspider.2_nochrome_paint: 14.5</a><br>
RETURN:<a href='http://graphs.allizom.org/graph.html#tests=[[165,106,12]]'>tdhtml.2_nochrome_paint: 283.59</a><br>
RETURN:<p style="font-size:smaller;">Details:<br>| <a href='http://graphs.allizom.org/graph.html#tests=[[163,106,12]]'>tsspider.2_nochrome_paint</a> | <a href='http://graphs.allizom.org/graph.html#tests=[[165,106,12]]'>tdhtml.2_nochrome_paint</a> |</p>

Comment 11

[Robert Helmer [:rhelmer]]

(In reply to Armen Zambrano G. [:armenzg] - Release Engineer from comment #10)
> rhelmer I believe this is fixed now:
> http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTest/1331153692.
> 1331153944.5590.gz&fulltext=1
> 
> * No warning
> * All URLs work 

Great! Does it look like the correct data points that this added show up etc?

> Anything else we should be checking? I think after you land your changes
> we're ready to go, no?

I think we're all set, we do need to get a build on production. I can file a bug for that.

> On another note, can you point us to the fix for the record?

Sure, ended up being these three:

http://hg.mozilla.org/users/rhelmer_mozilla.com/graphs/rev/474cc8e159f6
http://hg.mozilla.org/users/rhelmer_mozilla.com/graphs/rev/7ce48c6ac685
http://hg.mozilla.org/users/rhelmer_mozilla.com/graphs/rev/4eaf51d1418a

BTW this repo I have been keeping in sync with hg.m.o/graphs and plan to merge back in bug 721895.

Comment 12

[Armen [:armenzg]]

Attachment: switch to graphs.allizom.org

Comment 13

[Armen [:armenzg]]

Comment on attachment 603843 [details] [diff] [review]
switch to graphs.allizom.org

http://hg.mozilla.org/build/buildbot-configs/rev/b80e574ae650