Browser Quest: Double clicking with canvas causes zooming

RESOLVED WORKSFORME

Status

()

RESOLVED WORKSFORME
7 years ago
7 years ago

People

(Reporter: BenWa, Assigned: paul)

Tracking

(Blocks: 1 bug)

unspecified
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(blocking-fennec1.0 beta+)

Details

(Whiteboard: MAPLE mwc-demo)

(Reporter)

Description

7 years ago
When trying to play the game, clicking quickly leads to a double quick that does reflow/zoom behavior. It's either up to the game to catch these events or up to the front end to disable this behavior on canvas element?
(Assignee)

Comment 1

7 years ago
The game use user-scalable=no:

<meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1.0, user-scalable=no">

A double click should not be resizing the game. See bug 707571
preventDefault on touchdown should also prevent this. Is that happening Paul? I think there is a race somewhere in the touch event->preventPanning code that we lose sometimes, but I haven't been able to track it down. Or its possible the demo is only calling preventDefault on touchmove which never fires?
(Assignee)

Comment 3

7 years ago
We don't preventDefault on touchdown (touchstart?). I can do that.
Whoops. Yep, touchstart.

Like I said, I think I have seen that fail. I can invest some time this afternoon if its a priority.
(Assignee)

Comment 5

7 years ago
(In reply to Wesley Johnston (:wesj) from comment #4)
> Whoops. Yep, touchstart.
> 
> Like I said, I think I have seen that fail. I can invest some time this afternoon if its a priority.

I'll make some tests tomorrow and let you know.
(Reporter)

Comment 6

7 years ago
I also don't see any monsters outside of the town while the rats in town do load. I can walk all the way to the final boss without getting attack so I imagine it's not a platform canvas bug otherwise if the monster were there the character would get killed. Any idea where that bug is?
(Reporter)

Updated

7 years ago
Summary: Double clicking with canvas causes zooming → Browser Quest: Double clicking with canvas causes zooming
Is this maple-specific?
Assignee: nobody → paul
Keywords: fennecnative-betablocker
Whiteboard: MAPLE mwc-demo
This works for me using the current Maple tinderbox and Nightly.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Resolution: FIXED → WORKSFORME
I can kinda duplicate the issue by placing the device in landscape, but it doesn't reflow much and it doesn't seem to harm anything.
blocking-fennec1.0: --- → beta+
You need to log in before you can comment on or make changes to this bug.